Willy Tarreau 276cdc11e8 BUG/MEDIUM: htx: mark htx_sl as packed since it may be realigned ... A test on MIPS64 revealed that the following reg tests would all fail at the same place in htx_replace_stline() when updating parts of the request line: reg-tests/cache/if-modified-since.vtc reg-tests/http-rules/h1or2_to_h1c.vtc reg-tests/http-rules/http_after_response.vtc reg-tests/http-rules/normalize_uri.vtc reg-tests/http-rules/path_and_pathq.vtc While the status line is normally aligned since it's the first block of the HTX, it may become unaligned once replaced. The problem is, it is a structure which contains some u16 and u32, and dereferencing them on machines not natively supporting unaligned accesses makes them crash or handle crap. Typically, MIPS/MIPS64/SPARC will crash, ARMv5 will either crash or (more likely) return swapped values and do crap, and RISCV will trap and turn to slow emulation. We can assign the htx_sl struct the packed attribute, but then this also causes the ints to fill the 2-bytes gap before them, always causing unaligned accesses for this part on such machines. The patch does a bit better, by explicitly filling this two-bytes hole, and packing the struct. This should be backported to all versions.		2024-05-15 19:03:17 +02:00
..
haproxy	BUG/MEDIUM: htx: mark htx_sl as packed since it may be realigned	2024-05-15 19:03:17 +02:00
import	MINOR: ist: define iststrip() new function	2024-04-26 11:29:25 +02:00
make	BUILD: makefile: support USE_xxx=0 as well	2024-04-11 11:06:19 +02:00