mirror of
https://git.haproxy.org/git/haproxy.git/
synced 2025-12-22 01:51:31 +01:00
5b19d95850
The RX_F_INHERITED flag was ambiguous, as it was used to mark both listeners inherited from the parent process and listeners duplicated from another local receiver. This could lead to incorrect behavior concerning socket unbinding and suspension. This commit refactors the handling of inherited listeners by splitting the RX_F_INHERITED flag into two more specific flags: - RX_F_INHERITED_FD: Indicates a listener inherited from the parent process via its file descriptor. These listeners should not be unbound by the master. - RX_F_INHERITED_SOCK: Indicates a listener that shares a socket with another one, either by being inherited from the parent or by being duplicated from another local listener. These listeners should not be suspended or resumed individually. Previously, the sharding code was unconditionally using RX_F_INHERITED when duplicating a file descriptor. In HAProxy versions prior to 3.1, this led to a file descriptor leak for duplicated unix stats sockets in the master process. This would eventually cause the master to crash with a BUG_ON in fd_insert() once the file descriptor limit was reached. This must be backported as far as 3.0. Branches earlier than 3.0 are affected but would need a different patch as the logic is different.