mirror of
https://git.haproxy.org/git/haproxy.git/
synced 2025-08-16 20:17:00 +02:00
7d6270a845
This very old bug is there since the first implementation of newreno congestion algorithm implementation. This was a very bad idea to put a state variable into quic_cc_algo struct which only defines the congestion control algorithm used by a QUIC listener, typically its type and its callbacks. This bug could lead to crashes since BUG_ON() calls have been added to each algorithm implementation. This was revealed by interop test, but not very often as there was not very often several connections run at the time during these tests. Hopefully this was also reported by Tristan in GH #2095. Move the congestion algorithm state to the correct structures which are private to a connection (see cubic and nr structs). Must be backported to 2.7 and 2.6.
100 lines
2.5 KiB
C
100 lines
2.5 KiB
C
/*
|
|
* include/haproxy/quic_cc-t.h
|
|
* This file contains definitions for QUIC congestion control.
|
|
*
|
|
* Copyright 2020 HAProxy Technologies, Frederic Lecaille <flecaille@haproxy.com>
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation, version 2.1
|
|
* exclusively.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library; if not, write to the Free Software
|
|
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
|
|
*/
|
|
|
|
#ifndef _HAPROXY_QUIC_CC_H
|
|
#define _HAPROXY_QUIC_CC_H
|
|
#ifdef USE_QUIC
|
|
#ifndef USE_OPENSSL
|
|
#error "Must define USE_OPENSSL"
|
|
#endif
|
|
|
|
#include <inttypes.h>
|
|
#include <stddef.h> /* size_t */
|
|
|
|
#include <haproxy/buf-t.h>
|
|
|
|
#define QUIC_CC_INFINITE_SSTHESH ((uint32_t)-1)
|
|
|
|
extern struct quic_cc_algo quic_cc_algo_nr;
|
|
extern struct quic_cc_algo quic_cc_algo_cubic;
|
|
extern struct quic_cc_algo *default_quic_cc_algo;
|
|
|
|
/* Fake algorithm with its fixed window */
|
|
extern struct quic_cc_algo quic_cc_algo_nocc;
|
|
extern unsigned int quic_cc_nocc_fixed_cwnd;
|
|
|
|
extern unsigned long long last_ts;
|
|
|
|
enum quic_cc_algo_state_type {
|
|
/* Slow start. */
|
|
QUIC_CC_ST_SS,
|
|
/* Congestion avoidance. */
|
|
QUIC_CC_ST_CA,
|
|
/* Recovery period. */
|
|
QUIC_CC_ST_RP,
|
|
};
|
|
|
|
enum quic_cc_event_type {
|
|
/* ACK receipt. */
|
|
QUIC_CC_EVT_ACK,
|
|
/* Packet loss. */
|
|
QUIC_CC_EVT_LOSS,
|
|
/* ECN-CE. */
|
|
QUIC_CC_EVT_ECN_CE,
|
|
};
|
|
|
|
struct quic_cc_event {
|
|
enum quic_cc_event_type type;
|
|
union {
|
|
struct ack {
|
|
uint64_t acked;
|
|
unsigned int time_sent;
|
|
} ack;
|
|
struct loss {
|
|
unsigned int time_sent;
|
|
} loss;
|
|
};
|
|
};
|
|
|
|
enum quic_cc_algo_type {
|
|
QUIC_CC_ALGO_TP_NEWRENO,
|
|
QUIC_CC_ALGO_TP_CUBIC,
|
|
QUIC_CC_ALGO_TP_NOCC,
|
|
};
|
|
|
|
struct quic_cc {
|
|
/* <conn> is there only for debugging purpose. */
|
|
struct quic_conn *qc;
|
|
struct quic_cc_algo *algo;
|
|
uint32_t priv[16];
|
|
};
|
|
|
|
struct quic_cc_algo {
|
|
enum quic_cc_algo_type type;
|
|
int (*init)(struct quic_cc *cc);
|
|
void (*event)(struct quic_cc *cc, struct quic_cc_event *ev);
|
|
void (*slow_start)(struct quic_cc *cc);
|
|
void (*state_trace)(struct buffer *buf, const struct quic_cc *cc);
|
|
};
|
|
|
|
#endif /* USE_QUIC */
|
|
#endif /* _HAPROXY_QUIC_CC_H */
|