mirror of
https://git.haproxy.org/git/haproxy.git/
synced 2026-02-27 04:01:45 +01:00
18ed789ae2
In srv_cleanup_idle_connections(), we compute how many idle connections are in excess compared to the average need. But we may actually be missing some, for example if a certain number were recently closed and the average of used connections didn't change much since previous period. In this case exceed_conn can become negative. There was no special case for this in the code, and calculating the per-thread share of connections to kill based on this value resulted in special value -1 to be passed to srv_migrate_conns_to_remove(), which for this function means "kill all of them", as used in srv_cleanup_connections() for example. This causes large variations of idle connections counts on servers and CPU spikes at the moment the cleanup task passes. These were quite more visible with SSL as it costs CPU to close and re-establish these connections, and it also takes time, reducing the reuse ratio, hence increasing the amount of connections during reconnection. In this patch we simply skip the killing loop when this condition is met. No backport is needed, this is purely 2.2.
The HAProxy documentation has been split into a number of different files for ease of use. Please refer to the following files depending on what you're looking for : - INSTALL for instructions on how to build and install HAProxy - BRANCHES to understand the project's life cycle and what version to use - LICENSE for the project's license - CONTRIBUTING for the process to follow to submit contributions The more detailed documentation is located into the doc/ directory : - doc/intro.txt for a quick introduction on HAProxy - doc/configuration.txt for the configuration's reference manual - doc/lua.txt for the Lua's reference manual - doc/SPOE.txt for how to use the SPOE engine - doc/network-namespaces.txt for how to use network namespaces under Linux - doc/management.txt for the management guide - doc/regression-testing.txt for how to use the regression testing suite - doc/peers.txt for the peers protocol reference - doc/coding-style.txt for how to adopt HAProxy's coding style - doc/internals for developer-specific documentation (not all up to date)