mirror of
https://git.haproxy.org/git/haproxy.git/
synced 2025-11-16 00:11:16 +01:00
29b6d8af16
A better name was found for the option implemented in ec74438
("MINOR: hlua: add option to preserve bool type from smp to lua")
Indeed, "tune.lua.preserve-smp-bool {on | off}" wasn't explicit enough
nor did it encourage the adoption of the new "fixed" behavior (vs
historical behavior which is now considered as a bug).
Thus it becomes "tune.lua.bool-sample-conversion { normal | pre-3.1-bug }"
which actively encourage users to switch the new behavior after having
patched in-use Lua script if needed. From a technical point of view,
the logic remains the same, as the option currently defaults to
"pre-3.1-bug" to prevent script breakage, and a warning is emitted if
the option isn't set explicily and Lua is used.
Documentation and regtests were updated.
Must be backported in 3.1 with ec74438 and f2838f5 ("REGTESTS: fix
lua-based regtests using tune.lua.smp-preserve-bool")
55 lines
1.6 KiB
Plaintext
55 lines
1.6 KiB
Plaintext
# commit 70d318c
|
|
# BUG/MEDIUM: lua: possible CLOSE-WAIT state with '\n' headers
|
|
#
|
|
# The Lua parser doesn't takes in account end-of-headers containing
|
|
# only '\n'. It expects always '\r\n'. If a '\n' is processes the Lua
|
|
# parser considers it miss 1 byte, and wait indefinitely for new data.
|
|
#
|
|
# When the client reaches their timeout, it closes the connection.
|
|
# This close is not detected and the connection keep in CLOSE-WAIT
|
|
# state.
|
|
#
|
|
# I guess that this patch fix only a visible part of the problem.
|
|
# If the Lua HTTP parser wait for data, the timeout server or the
|
|
# connectio closed by the client may stop the applet.
|
|
|
|
varnishtest "possible CLOSE-WAIT with '\n' headers"
|
|
#REQUIRE_OPTIONS=LUA
|
|
#REGTEST_TYPE=bug
|
|
|
|
feature ignore_unknown_macro
|
|
|
|
syslog Slog -level info -repeat 100 {
|
|
recv info
|
|
expect ~ "[^:\\[ ]\\[${h1_pid}\\]: Ta=[0-9]* Tc=[0-9]* Td=[0-9]* Th=[0-9]* Ti=[0-9]* Tq=[0-9]* TR=[0-9]* Tr=[0-9]* Tt=[0-9]* Tw=[0-9]*"
|
|
} -start
|
|
|
|
haproxy h1 -conf {
|
|
defaults
|
|
timeout client "${HAPROXY_TEST_TIMEOUT-5s}"
|
|
timeout connect "${HAPROXY_TEST_TIMEOUT-5s}"
|
|
|
|
global
|
|
tune.lua.bool-sample-conversion normal
|
|
lua-load ${testdir}/close_wait_lf.lua
|
|
|
|
frontend frt
|
|
log ${Slog_addr}:${Slog_port} local0 debug err
|
|
log-format Ta=%Ta\ Tc=%Tc\ Td=%Td\ Th=%Th\ Ti=%Ti\ Tq=%Tq\ TR=%TR\ Tr=%Tr\ Tt=%Tt\ Tw=%Tw
|
|
mode http
|
|
bind "fd@${frt}"
|
|
http-request use-service lua.donothing
|
|
} -start
|
|
|
|
|
|
client c1 -connect ${h1_frt_sock} -repeat 100 {
|
|
send "GET / HTTP/1.1\n\n"
|
|
} -run
|
|
|
|
syslog Slog -wait
|
|
|
|
shell {
|
|
ss -pt | grep CLOSE-WAIT.*haproxy.*pid=${h1_pid}
|
|
exit $((!$?))
|
|
}
|