08f557f0c4
TASK_F_USR1 is used by MUX tasklet when emission has been interrupted due to pacing. When the tasklet runs again, only qcc_purge_sending() will be called as an optimization. Pacing status is only removed via qcc_wakeup(). Until then, TASK_F_USR1 is not cleared. This causes an issue after emission with pacing completion if the MUX tasklet is woken up for a recv subscribe, as qcc_wakeup() is not used by quic-conn layer. The tasklet will incorrectly run only for pacing emission, without handling reception process. Worst, a crash will occur if QCC tx frames list is empty, due to a BUG_ON() in qcc_purge_sending(). Recv subscribe is only used for 0-RTT, when QUIC MUX is instantiated before quic-conn handshake completion. Thus, this bug can only be reproduced with 0-rtt. Furthermore, MUX must already have emitted at least a few response bytes with pacing, before QUIC handshake completion. It cannot easily be reproduced, at least with CLI clients where the handshake is always already completed before MUX exchanges. To fix this, remove TASK_F_USR1 when pacing emission has been completed. At least, this prevents BUG_ON() on qcc_purge_sending() as it won't be called with an empty QCC Tx frame list anymore. However, this bug has revealed that MUX tasklet architecture is not suitable when both handling reception and emission part. This will be improved in a future serie of patches. This should fix github issue #2796. This must be backported up to 3.1. |
||
|---|---|---|
| .github | ||
| addons | ||
| admin | ||
| dev | ||
| doc | ||
| examples | ||
| include | ||
| reg-tests | ||
| scripts | ||
| src | ||
| tests | ||
| .cirrus.yml | ||
| .gitattributes | ||
| .gitignore | ||
| .mailmap | ||
| .travis.yml | ||
| BRANCHES | ||
| BSDmakefile | ||
| CHANGELOG | ||
| CONTRIBUTING | ||
| INSTALL | ||
| LICENSE | ||
| MAINTAINERS | ||
| Makefile | ||
| README.md | ||
| SUBVERS | ||
| VERDATE | ||
| VERSION | ||
HAProxy
HAProxy is a free, very fast and reliable reverse-proxy offering high availability, load balancing, and proxying for TCP and HTTP-based applications.
Installation
The INSTALL file describes how to build HAProxy. A list of packages is also available on the wiki.
Getting help
The discourse and the mailing-list are available for questions or configuration assistance. You can also use the slack or IRC channel. Please don't use the issue tracker for these.
The issue tracker is only for bug reports or feature requests.
Documentation
The HAProxy documentation has been split into a number of different files for ease of use. It is available in text format as well as HTML. The wiki is also meant to replace the old architecture guide.
Please refer to the following files depending on what you're looking for:
- INSTALL for instructions on how to build and install HAProxy
- BRANCHES to understand the project's life cycle and what version to use
- LICENSE for the project's license
- CONTRIBUTING for the process to follow to submit contributions
The more detailed documentation is located into the doc/ directory:
- doc/intro.txt for a quick introduction on HAProxy
- doc/configuration.txt for the configuration's reference manual
- doc/lua.txt for the Lua's reference manual
- doc/SPOE.txt for how to use the SPOE engine
- doc/network-namespaces.txt for how to use network namespaces under Linux
- doc/management.txt for the management guide
- doc/regression-testing.txt for how to use the regression testing suite
- doc/peers.txt for the peers protocol reference
- doc/coding-style.txt for how to adopt HAProxy's coding style
- doc/internals for developer-specific documentation (not all up to date)
License
HAProxy is licensed under GPL 2 or any later version, the headers under LGPL 2.1. See the LICENSE file for a more detailed explanation.