mirror of
https://git.haproxy.org/git/haproxy.git/
synced 2025-08-16 03:56:56 +02:00
When the connection for sink_forward_{oc}_applet fails or a previous one is destroyed, the sft->appctx is instantly released. However process_sink_forward_task(), which may run at any time, iterates over all known sfts and tries to create sessions for orphan ones. It means that instantly after sft->appctx is destroyed, a new one will be created, thus a new connection attempt will be made. It can be an issue with tcp log-servers or sink servers, because if the server is unavailable, process_sink_forward() will keep looping without any temporisation until the applet survives (ie: connection succeeds), which results in unexpected CPU usage on the threads responsible for that task. Instead, we add a tempo logic so that a delay of 1second is applied between two retries. Of course the initial attempt is not delayed. This could be backported to all stable versions.
83 lines
3.1 KiB
C
83 lines
3.1 KiB
C
/*
|
|
* include/haproxy/sink-t.h
|
|
* This file provides definitions for event sinks
|
|
*
|
|
* Copyright (C) 2000-2019 Willy Tarreau - w@1wt.eu
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation, version 2.1
|
|
* exclusively.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library; if not, write to the Free Software
|
|
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
|
|
*/
|
|
|
|
#ifndef _HAPROXY_SINK_T_H
|
|
#define _HAPROXY_SINK_T_H
|
|
|
|
#include <import/ist.h>
|
|
#include <haproxy/api-t.h>
|
|
#include <haproxy/log-t.h>
|
|
|
|
/* A sink may be of 4 distinct types :
|
|
* - file descriptor (such as stdout)
|
|
* - ring buffer, readable from CLI
|
|
*/
|
|
enum sink_type {
|
|
SINK_TYPE_FORWARD_DECLARED, // was searched using sink_find_early(), is expected to exist by some component
|
|
SINK_TYPE_NEW, // not yet initialized
|
|
SINK_TYPE_FD, // events sent to a file descriptor
|
|
SINK_TYPE_BUFFER, // events sent to a ring buffer
|
|
};
|
|
|
|
struct sink_forward_target {
|
|
struct server *srv; // used server
|
|
struct appctx *appctx; // appctx of current session
|
|
uint last_conn; // copy of now_ms for last session establishment attempt
|
|
size_t ofs; // ring buffer reader offset
|
|
size_t e_processed; // processed events
|
|
struct sink *sink; // the associated sink
|
|
struct sink_forward_target *next;
|
|
__decl_thread(HA_SPINLOCK_T lock); // lock to protect current struct
|
|
};
|
|
|
|
/* describes the configuration and current state of an event sink */
|
|
struct sink {
|
|
struct list sink_list; // position in the sink list
|
|
char *name; // sink name
|
|
char *desc; /* sink description:
|
|
* when forward-declared, holds info about where the
|
|
* sink was first forward declared, else holds actual
|
|
* sink description
|
|
*/
|
|
char *store; // backing-store file when buffer
|
|
enum log_fmt fmt; // format expected by the sink
|
|
enum sink_type type; // type of storage
|
|
uint32_t maxlen; // max message length (truncated above)
|
|
struct proxy* forward_px; // internal proxy used to forward (only set when exclusive to sink)
|
|
struct sink_forward_target *sft; // sink forward targets
|
|
struct task *forward_task; // task to handle forward targets conns
|
|
struct sig_handler *forward_sighandler; /* signal handler */
|
|
struct {
|
|
struct ring *ring; // used by ring buffer and STRM sender
|
|
unsigned int dropped; // 2*dropped events since last one + 1 for purge in progress.
|
|
int fd; // fd num for FD type sink
|
|
} ctx;
|
|
};
|
|
|
|
#endif /* _HAPROXY_SINK_T_H */
|
|
|
|
/*
|
|
* Local variables:
|
|
* c-indent-level: 8
|
|
* c-basic-offset: 8
|
|
* End:
|
|
*/
|