mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-09-26 08:11:21 +02:00
Code Issues Projects Releases Wiki Activity
haproxy/src
History
Tim Duesterhus 041a626a8a BUG/MINOR: sample: Free str.area in smp_check_const_meth 
Given the following example configuration:

    listen foo
    	mode http
    	bind *:8080
    	http-request set-var(txn.leak) meth(GET)
    	server x example.com:80

Running a configuration check with valgrind reports:

    ==25992== 4 bytes in 1 blocks are definitely lost in loss record 1 of 344
    ==25992==    at 0x4C2DB8F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
    ==25992==    by 0x4E239D: my_strndup (tools.c:2261)
    ==25992==    by 0x581E20: make_arg_list (arg.c:253)
    ==25992==    by 0x4DE91D: sample_parse_expr (sample.c:890)
    ==25992==    by 0x58E304: parse_store (vars.c:772)
    ==25992==    by 0x566A3F: parse_http_req_cond (http_rules.c:95)
    ==25992==    by 0x4A4CE6: cfg_parse_listen (cfgparse-listen.c:1339)
    ==25992==    by 0x494C59: readcfgfile (cfgparse.c:2049)
    ==25992==    by 0x545145: init (haproxy.c:2029)
    ==25992==    by 0x421E42: main (haproxy.c:3175)

After this patch is applied the leak is gone as expected.

This is a fairly minor leak, but it can add up for many uses of the `bool()`
sample fetch. The bug most likely exists since the `bool()` sample fetch was
introduced in commit cc103299c75c530ab3637a1698306145bdc85552. The fix may
be backported to HAProxy 1.6+.
2020-07-07 16:52:35 +02:00
..
51d.c
MINOR: 51d: silence a warning about null pointer dereference
2020-07-01 23:27:06 +02:00
acl.c
BUG/MINOR: acl: Fix freeing of expr->smp in prune_acl_expr
2020-07-07 16:52:35 +02:00
action.c
CLEANUP: include: tree-wide alphabetical sort of include files
2020-06-11 10:18:59 +02:00
activity.c
CLEANUP: include: tree-wide alphabetical sort of include files
2020-06-11 10:18:59 +02:00
applet.c
CLEANUP: include: tree-wide alphabetical sort of include files
2020-06-11 10:18:59 +02:00
arg.c
CLEANUP: assorted typo fixes in the code and comments
2020-07-06 14:34:32 +02:00
auth.c
CLEANUP: include: tree-wide alphabetical sort of include files
2020-06-11 10:18:59 +02:00
backend.c
BUG/MEDIUM: connection: Don't consider new private connections as available
2020-07-07 14:30:38 +02:00
base64.c
REORG: include: move base64.h, errors.h and hash.h from common to to haproxy/
2020-06-11 10:18:56 +02:00
cache.c
CLEANUP: include: tree-wide alphabetical sort of include files
2020-06-11 10:18:59 +02:00
calltrace.c
REORG: include: move time.h from common/ to haproxy/
2020-06-11 10:18:56 +02:00
cfgparse-global.c
MINOR: config: make strict limits enabled by default
2020-07-07 16:52:35 +02:00
cfgparse-listen.c
CLEANUP: include: tree-wide alphabetical sort of include files
2020-06-11 10:18:59 +02:00
cfgparse-ssl.c
WIP/MINOR: ssl: add sample fetches for keylog in frontend
2020-07-06 19:08:03 +02:00
cfgparse.c
MINOR: log-format: allow to preserve spacing in log format strings
2020-07-02 10:11:44 +02:00
channel.c
REORG: include: move channel.h to haproxy/channel{,-t}.h
2020-06-11 10:18:58 +02:00
check.c
BUG/MEDIUM: checks: Fix off-by-one in allocation of SMTP greeting cmd
2020-06-12 16:18:02 +02:00
chunk.c
CLEANUP: include: tree-wide alphabetical sort of include files
2020-06-11 10:18:59 +02:00
cli.c
MINOR: activity: add per-thread statistics on FD takeover
2020-06-29 14:26:05 +02:00
compression.c
BUILD: compression: make gcc 10 happy with free_zlib()
2020-06-14 08:00:19 +02:00
connection.c
BUG/MINOR: connection: See new connection as available only on reuse always
2020-07-07 14:31:01 +02:00
da.c
CLEANUP: include: tree-wide alphabetical sort of include files
2020-06-11 10:18:59 +02:00
debug.c
BUILD: tools: make resolve_sym_name() return a const
2020-07-05 20:26:04 +02:00
dgram.c
REORG: dgram: rename proto_udp to dgram
2020-06-11 10:18:59 +02:00
dict.c
REORG: include: move THREAD_LOCAL and __decl_thread() to compiler.h
2020-06-11 10:18:59 +02:00
dns.c
CLEANUP: assorted typo fixes in the code and comments
2020-07-06 14:34:32 +02:00
dynbuf.c
REORG: buffer: rename buffer.c to dynbuf.c
2020-06-29 09:26:59 +02:00
eb32sctree.c
REORG: ebtree: move the include files from ebtree to include/import/
2020-06-11 09:31:11 +02:00
eb32tree.c
REORG: ebtree: move the include files from ebtree to include/import/
2020-06-11 09:31:11 +02:00
eb64tree.c
REORG: ebtree: move the include files from ebtree to include/import/
2020-06-11 09:31:11 +02:00
ebimtree.c
CLEANUP: include: tree-wide alphabetical sort of include files
2020-06-11 10:18:59 +02:00
ebistree.c
REORG: ebtree: move the include files from ebtree to include/import/
2020-06-11 09:31:11 +02:00
ebmbtree.c
REORG: ebtree: move the include files from ebtree to include/import/
2020-06-11 09:31:11 +02:00
ebpttree.c
REORG: ebtree: move the include files from ebtree to include/import/
2020-06-11 09:31:11 +02:00
ebsttree.c
REORG: ebtree: move the include files from ebtree to include/import/
2020-06-11 09:31:11 +02:00
ebtree.c
BUG/MEDIUM: ebtree: use a byte-per-byte memcmp() to compare memory blocks
2020-06-16 11:30:33 +02:00
ev_epoll.c
MINOR: debug: add a new DEBUG_FD build option
2020-06-23 10:04:54 +02:00
ev_evports.c
MINOR: debug: add a new DEBUG_FD build option
2020-06-23 10:04:54 +02:00
ev_kqueue.c
MINOR: debug: add a new DEBUG_FD build option
2020-06-23 10:04:54 +02:00
ev_poll.c
MINOR: debug: add a new DEBUG_FD build option
2020-06-23 10:04:54 +02:00
ev_select.c
MINOR: debug: add a new DEBUG_FD build option
2020-06-23 10:04:54 +02:00
extcheck.c
REORG: include: move the error reporting functions to from log.h to errors.h
2020-06-11 10:18:59 +02:00
fcgi-app.c
CLEANUP: assorted typo fixes in the code and comments
2020-07-06 14:34:32 +02:00
fcgi.c
CLEANUP: include: tree-wide alphabetical sort of include files
2020-06-11 10:18:59 +02:00
fd.c
MINOR: debug: add a new DEBUG_FD build option
2020-06-23 10:04:54 +02:00
filters.c
REORG: include: move cfgparse.h to haproxy/cfgparse.h
2020-06-11 10:18:58 +02:00
flt_http_comp.c
CLEANUP: assorted typo fixes in the code and comments
2020-07-06 14:34:32 +02:00
flt_spoe.c
MINOR: spoe: Don't systematically create new applets if processing rate is low
2020-06-25 21:50:20 +02:00
flt_trace.c
CLEANUP: include: tree-wide alphabetical sort of include files
2020-06-11 10:18:59 +02:00
freq_ctr.c
CLEANUP: include: tree-wide alphabetical sort of include files
2020-06-11 10:18:59 +02:00
frontend.c
CLEANUP: include: tree-wide alphabetical sort of include files
2020-06-11 10:18:59 +02:00
h1_htx.c
CLEANUP: assorted typo fixes in the code and comments
2020-06-26 11:27:28 +02:00
h1.c
BUILD: tree-wide: cast arguments to tolower/toupper to unsigned char
2020-07-05 21:50:02 +02:00
h2.c
CLEANUP: include: tree-wide alphabetical sort of include files
2020-06-11 10:18:59 +02:00
haproxy.c
BUG/MINOR: haproxy: Free srule->expr during deinit
2020-07-07 16:52:35 +02:00
hash.c
REORG: include: move base64.h, errors.h and hash.h from common to to haproxy/
2020-06-11 10:18:56 +02:00
hlua_fcn.c
CLEANUP: include: tree-wide alphabetical sort of include files
2020-06-11 10:18:59 +02:00
hlua.c
CLEANUP: assorted typo fixes in the code and comments
2020-07-06 14:34:32 +02:00
hpack-dec.c
CLEANUP: include: tree-wide alphabetical sort of include files
2020-06-11 10:18:59 +02:00
hpack-enc.c
CLEANUP: include: tree-wide alphabetical sort of include files
2020-06-11 10:18:59 +02:00
hpack-huff.c
REORG: include: move hpack*.h to haproxy/ and split hpack-tbl
2020-06-11 10:18:57 +02:00
hpack-tbl.c
CLEANUP: include: tree-wide alphabetical sort of include files
2020-06-11 10:18:59 +02:00
http_acl.c
CLEANUP: include: tree-wide alphabetical sort of include files
2020-06-11 10:18:59 +02:00
http_act.c
BUG/MINOR: http_act: don't check capture id in backend (2)
2020-07-03 18:30:54 +02:00
http_ana.c
CLEANUP: assorted typo fixes in the code and comments
2020-07-06 14:34:32 +02:00
http_conv.c
CLEANUP: assorted typo fixes in the code and comments
2020-07-06 14:34:32 +02:00
http_fetch.c
CLEANUP: assorted typo fixes in the code and comments
2020-07-06 14:34:32 +02:00
http_htx.c
CLEANUP: assorted typo fixes in the code and comments
2020-06-26 11:27:28 +02:00
http_rules.c
CLEANUP: include: tree-wide alphabetical sort of include files
2020-06-11 10:18:59 +02:00
http.c
CLEANUP: assorted typo fixes in the code and comments
2020-07-06 14:34:32 +02:00
htx.c
CLEANUP: assorted typo fixes in the code and comments
2020-07-06 14:34:32 +02:00
lb_chash.c
CLEANUP: include: tree-wide alphabetical sort of include files
2020-06-11 10:18:59 +02:00
lb_fas.c
CLEANUP: include: tree-wide alphabetical sort of include files
2020-06-11 10:18:59 +02:00
lb_fwlc.c
CLEANUP: include: tree-wide alphabetical sort of include files
2020-06-11 10:18:59 +02:00
lb_fwrr.c
CLEANUP: include: tree-wide alphabetical sort of include files
2020-06-11 10:18:59 +02:00
lb_map.c
CLEANUP: include: tree-wide alphabetical sort of include files
2020-06-11 10:18:59 +02:00
listener.c
CLEANUP: include: tree-wide alphabetical sort of include files
2020-06-11 10:18:59 +02:00
log.c
MINOR: log: Remove unused case statement during the log-format string parsing
2020-07-07 14:28:43 +02:00
lru.c
MINOR: lru: new function to delete <nb> least recently used keys
2016-01-11 07:31:35 +01:00
mailers.c
CLEANUP: include: tree-wide alphabetical sort of include files
2020-06-11 10:18:59 +02:00
map.c
MEDIUM: map: make the "clear map" operation yield
2020-06-19 16:57:51 +02:00
mux_fcgi.c
BUG/MEDIUM: connections: Let the xprt layer know a takeover happened.
2020-07-03 17:49:33 +02:00
mux_h1.c
MINOR: mux-h1: Improve traces about the splicing
2020-07-07 14:29:18 +02:00
mux_h2.c
CLEANUP: assorted typo fixes in the code and comments
2020-07-06 14:34:32 +02:00
mux_pt.c
CLEANUP: assorted typo fixes in the code and comments
2020-07-06 14:34:32 +02:00
mworker-prog.c
REORG: include: move the error reporting functions to from log.h to errors.h
2020-06-11 10:18:59 +02:00
mworker.c
CLEANUP: include: tree-wide alphabetical sort of include files
2020-06-11 10:18:59 +02:00
namespace.c
REORG: include: move the error reporting functions to from log.h to errors.h
2020-06-11 10:18:59 +02:00
pattern.c
BUILD: tree-wide: cast arguments to tolower/toupper to unsigned char
2020-07-05 21:50:02 +02:00
payload.c
CLEANUP: include: tree-wide alphabetical sort of include files
2020-06-11 10:18:59 +02:00
peers.c
CLEANUP: assorted typo fixes in the code and comments
2020-07-06 14:34:32 +02:00
pipe.c
CLEANUP: include: tree-wide alphabetical sort of include files
2020-06-11 10:18:59 +02:00
pool.c
MINOR: pools: move the LRU cache heads to thread_info
2020-06-29 10:36:37 +02:00
proto_sockpair.c
CLEANUP: include: tree-wide alphabetical sort of include files
2020-06-11 10:18:59 +02:00
proto_tcp.c
CLEANUP: assorted typo fixes in the code and comments
2020-07-06 14:34:32 +02:00
proto_uxst.c
CLEANUP: assorted typo fixes in the code and comments
2020-06-26 11:27:28 +02:00
protocol.c
CLEANUP: include: tree-wide alphabetical sort of include files
2020-06-11 10:18:59 +02:00
proxy.c
BUG/MEDIUM: cli/proxy: don't try to dump idle connection state if there's none
2020-07-02 15:19:57 +02:00
queue.c
CLEANUP: include: tree-wide alphabetical sort of include files
2020-06-11 10:18:59 +02:00
raw_sock.c
CLEANUP: include: tree-wide alphabetical sort of include files
2020-06-11 10:18:59 +02:00
regex.c
CLEANUP: assorted typo fixes in the code and comments
2020-07-06 14:34:32 +02:00
ring.c
CLEANUP: include: tree-wide alphabetical sort of include files
2020-06-11 10:18:59 +02:00
sample.c
BUG/MINOR: sample: Free str.area in smp_check_const_meth
2020-07-07 16:52:35 +02:00
server.c
BUG/MEDIUM: server: don't kill all idle conns when there are not enough
2020-07-02 19:05:30 +02:00
session.c
REORG: include: move stream.h to haproxy/stream{,-t}.h
2020-06-11 10:18:58 +02:00
sha1.c
BUILD: use inttypes.h instead of stdint.h
2019-04-01 07:44:56 +02:00
shctx.c
REORG: include: split global.h into haproxy/global{,-t}.h
2020-06-11 10:18:58 +02:00
signal.c
REORG: include: move the error reporting functions to from log.h to errors.h
2020-06-11 10:18:59 +02:00
sink.c
CLEANUP: assorted typo fixes in the code and comments
2020-07-06 14:34:32 +02:00
ssl_ckch.c
CLEANUP: assorted typo fixes in the code and comments
2020-07-06 14:34:32 +02:00
ssl_crtlist.c
MINOR: cli/ssl: handle trailing slashes in crt-list commands
2020-06-25 15:40:10 +02:00
ssl_sample.c
CLEANUP: ssl: remove unrelevant comment in smp_fetch_ssl_x_keylog()
2020-07-07 16:14:08 +02:00
ssl_sock.c
WIP/MINOR: ssl: add sample fetches for keylog in frontend
2020-07-06 19:08:03 +02:00
ssl_utils.c
REORG: include: move ssl_sock.h to haproxy/ssl_sock{,-t}.h
2020-06-11 10:18:58 +02:00
stats.c
MINOR: stats: add the estimated need of concurrent connections per server
2020-06-29 16:29:11 +02:00
stick_table.c
CLEANUP: assorted typo fixes in the code and comments
2020-06-26 11:27:28 +02:00
stream_interface.c
BUG/MINOR: stream-int: Don't wait to send truncated HTTP messages
2020-06-25 21:50:20 +02:00
stream.c
MINOR: cli: make "show sess" stop at the last known session
2020-06-28 01:41:56 +02:00
task.c
BUG/MAJOR: sched: make it work also when not building with DEBUG_STRICT
2020-07-02 17:17:42 +02:00
tcp_rules.c
BUG/MINOR: tcp-rules: tcp-response must check the buffer's fullness
2020-06-15 18:16:20 +02:00
tcpcheck.c
BUG/MEDIUM: checks: Increment the server's curr_used_conns
2020-06-28 16:23:09 +02:00
thread.c
CLEANUP: include: tree-wide alphabetical sort of include files
2020-06-11 10:18:59 +02:00
time.c
CLEANUP: assorted typo fixes in the code and comments
2020-07-06 14:34:32 +02:00
tools.c
CLEANUP: assorted typo fixes in the code and comments
2020-07-06 14:34:32 +02:00
trace.c
REORG: include: move the error reporting functions to from log.h to errors.h
2020-06-11 10:18:59 +02:00
uri_auth.c
REORG: include: move the error reporting functions to from log.h to errors.h
2020-06-11 10:18:59 +02:00
vars.c
CLEANUP: assorted typo fixes in the code and comments
2020-07-06 14:34:32 +02:00
version.c
BUILD: Fix build by including haproxy/global.h
2020-06-16 23:36:04 +02:00
wdt.c
REORG: include: move the error reporting functions to from log.h to errors.h
2020-06-11 10:18:59 +02:00
wurfl.c
CLEANUP: include: tree-wide alphabetical sort of include files
2020-06-11 10:18:59 +02:00
xprt_handshake.c
REORG: include: move stream_interface.h to haproxy/stream_interface{,-t}.h
2020-06-11 10:18:58 +02:00
xxhash.c
BUILD: use inttypes.h instead of stdint.h
2019-04-01 07:44:56 +02:00