mirror of
https://git.haproxy.org/git/haproxy.git/
synced 2025-11-14 23:41:20 +01:00
025945f12c
Obviously, frames which are duplicated from others must not be retransmitted if the original frame they were duplicated from was already acknowledged. This should have been detected by qc_build_frms() which skips such frames, except if the QUIC xprt does really bad things which are not supported by the upper layer. This will have to be checked with Amaury. To prevent the retransmision of these frames which leads to crashes as reported by hpn0t0ad this gdb backtrace in GH #1809 where the frame builder tries to copy a huge number of bytes to the packet buffer: Thread 7 (Thread 0x7fddf373a700 (LWP 13)): #0 __memmove_sse2_unaligned_erms () at ../sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S:520 No locals. #1 0x000055b17435705e in quic_build_stream_frame (buf=0x7fddf372ef78, end=<optimized out>, frm=0x7fdde08d3470, conn=<optimized out>) at src/quic_frame.c:515 to_copy = 18446697703428890384 stream = 0x7fdde08d3490 wrap = <optimized out> which matches this part of quic_frame.c code: wrap = (const unsigned char *)b_wrap(stream->buf); if (stream->data + stream->len > wrap) { size_t to_copy = wrap - stream->data; memcpy(*buf, stream->data, to_copy); *buf += to_copy; we release as soon as possible the impacted frames as there is really no need to retransmit such frames. Thank you to @hpn0t0ad for having provided us with useful traces in github issue #1809. Must be backported in 2.6.
The HAProxy documentation has been split into a number of different files for ease of use. Please refer to the following files depending on what you're looking for : - INSTALL for instructions on how to build and install HAProxy - BRANCHES to understand the project's life cycle and what version to use - LICENSE for the project's license - CONTRIBUTING for the process to follow to submit contributions The more detailed documentation is located into the doc/ directory : - doc/intro.txt for a quick introduction on HAProxy - doc/configuration.txt for the configuration's reference manual - doc/lua.txt for the Lua's reference manual - doc/SPOE.txt for how to use the SPOE engine - doc/network-namespaces.txt for how to use network namespaces under Linux - doc/management.txt for the management guide - doc/regression-testing.txt for how to use the regression testing suite - doc/peers.txt for the peers protocol reference - doc/coding-style.txt for how to adopt HAProxy's coding style - doc/internals for developer-specific documentation (not all up to date)