mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-08-06 07:07:04 +02:00
Code Issues Projects Releases Wiki Activity

MINOR: sink: inform the user when logs will be implicitly truncated

Browse Source 
Consider the following example:

 |log ring@test-ring len 2000 local0
 |
 |ring test-ring
 |  maxlen 1000

This would result in emitted logs being silently truncated to 1000 because
test-ring maxlen is smaller than the log directive maxlen.

In this patch we're adding an extra check in post_sink_resolve() to detect
this kind of confusing setups and warn the user about the implicit
truncation when DIAG mode is on.

This commit depends on:
 - "MINOR: sink: simplify post_sink_resolve function"
This commit is contained in:
Aurelien DARRAGON 2023-06-22 17:04:43 +02:00 committed by Christopher Faulet
parent ceaa1ddb06
commit fdf82d058b
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/sink.c
View File

@ -1305,6 +1305,12 @@ int sink_postresolve_logsrvs(struct list *logsrvs, const char *section, const ch
logsrv->conf.file, logsrv->conf.line,
logsrv->ring_name, (unsigned long)ring_max_payload(sink->ctx.ring));
}
else if (sink && logsrv->maxlen > sink->maxlen) {
_e_sink_postresolve_logsrvs(ha_diag_warning, "log server", "uses a ring with a smaller maxlen than the one specified on the log directive ('%s' has maxlen = %d), logs will be truncated according to the lowest maxlen between the two.",
section, section_name,
logsrv->conf.file, logsrv->conf.line,
logsrv->ring_name, sink->maxlen);
}
logsrv->sink = sink;
}