mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-08-06 07:07:04 +02:00
Code Issues Projects Releases Wiki Activity

BUG/MINOR: stream: Avoid recursive evaluation for unique-id based on itself

Browse Source 
There is nothing that prevent a "unique-id-format" to reference itself,
using '%ID' or '%[unique-id]'. If the sample fetch function is used, it
leads to an infinite loop, calling recursively the function responsible to
generate the unique ID.

One solution is to detect it during the configuration parsing to trigger an
error. With this patch, we just inhibit recursive calls by considering the
unique-id as empty during its evaluation. So "id-%[unique-id]" lf string
will be evaluated as "id-".

This patch must be backported to all stable versions.
This commit is contained in:
Christopher Faulet 2025-06-23 07:33:06 +02:00
parent 68c3eb3013
commit fb7b5c8a53
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/stream.c
View File

@ -2942,12 +2942,12 @@ struct ist stream_generate_unique_id(struct stream *strm, struct lf_expr *format
}
else {
char *unique_id;
int length;
if ((unique_id = pool_alloc(pool_head_uniqueid)) == NULL)
return IST_NULL;
length = build_logline(strm, unique_id, UNIQUEID_LEN, format);
strm->unique_id = ist2(unique_id, length);
strm->unique_id = ist2(unique_id, 0);
strm->unique_id.len = build_logline(strm, unique_id, UNIQUEID_LEN, format);
return strm->unique_id;
}