From fade49d8fbe54ba9643d0fe30534489695bff2fb Mon Sep 17 00:00:00 2001 From: William Lallemand Date: Wed, 15 Nov 2017 19:02:57 +0100 Subject: [PATCH] BUG/MEDIUM: mworker: does not deinit anymore Does not use the deinit() function during a reload, it's dangerous and might be subject to double free, segfault and hazardous behavior if it's called twice in the case of a execvp fail. --- src/haproxy.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/haproxy.c b/src/haproxy.c index b90e2540b..00cc25b16 100644 --- a/src/haproxy.c +++ b/src/haproxy.c @@ -648,7 +648,6 @@ static void mworker_reload() next_argv[next_argc++] = NULL; } - deinit(); /* we don't want to leak FD there */ Warning("Reexecuting Master process\n"); execvp(next_argv[0], next_argv);