mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-09-20 13:21:29 +02:00
Code Issues Projects Releases Wiki Activity

BUG/MINOR: server: Duplicate healthcheck's sni inherited from default server

Browse Source 
It is not really an issue, but the "check-sni" value inerited from a default
server is not duplicated while the paramter value is duplicated during the
parsing. So here there is a small leak if several "check-sni" parameters are
used on the same server line. The previous value is never released. But to
fix this issue, the value inherited from the default server must also be
duplicated. At the end it is safer this way and consistant with the parsing
of the "sni" parameter.

It is harmless so there is no reason to backport this patch.
This commit is contained in:
Christopher Faulet 2025-09-01 15:13:07 +02:00
parent f7a04b428a
commit f8b7299ee7
3 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/cfgparse-ssl.c
View File

@ -1651,6 +1651,7 @@ static int srv_parse_check_sni(char **args, int *cur_arg, struct proxy *px, stru
return ERR_ALERT | ERR_FATAL;
}
free(newsrv->check.sni);
newsrv->check.sni = strdup(args[*cur_arg + 1]);
if (!newsrv->check.sni) {
memprintf(err, "'%s' : failed to allocate memory", args[*cur_arg]);

1
src/check.c
View File

@ -1574,6 +1574,7 @@ void free_check(struct check *check)
}
ha_free(&check->pool_conn_name);
ha_free(&check->sni);
ha_free(&check->alpn_str);
task_destroy(check->task);

3
src/server.c
View File

@ -2900,7 +2900,8 @@ void srv_settings_cpy(struct server *srv, const struct server *src, int srv_tmpl
srv->agent.addr = src->agent.addr;
srv->check.use_ssl = src->check.use_ssl;
srv->check.port = src->check.port;
srv->check.sni = src->check.sni;
if (src->check.sni != NULL)
srv->check.sni = strdup(src->check.sni);
if (src->check.alpn_str) {
srv->check.alpn_str = malloc(src->check.alpn_len);
if (srv->check.alpn_str) {