mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-09-23 06:41:32 +02:00
Code Issues Projects Releases Wiki Activity

BUG/MINOR: mux_quic: make sure to always apply offsets to now_ms in expiration

Browse Source 
Now_ms can be zero nowadays, so it's not suitable for direct assignment to
t->expire, as there's a risk that the timer never wakes up once assigned
(TICK_ETERNITY). Let's use tick_add(now_ms, 0) for an immediate wakeup
instead. The impact looks nul since the task is also woken up, but better
not leave such tasks in the timer tree anyway.

This should be backported where it applies.
This commit is contained in:
Willy Tarreau 2024-11-15 15:41:21 +01:00
parent 841be4cdd1
commit f66bfcff96
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/mux_quic.c
View File

@ -366,7 +366,7 @@ static void qcc_refresh_timeout(struct qcc *qcc)
/* We are past the soft close window end, wake the timeout /* We are past the soft close window end, wake the timeout
* task up immediately. * task up immediately.
*/ */
qcc->task->expire = now_ms; qcc->task->expire = tick_add(now_ms, 0);
task_wakeup(qcc->task, TASK_WOKEN_TIMER); task_wakeup(qcc->task, TASK_WOKEN_TIMER);
} }
} }