From f58883002c6fd90b3bf8a70e779b7e72e76cec2c Mon Sep 17 00:00:00 2001 From: Christopher Faulet Date: Fri, 19 Apr 2024 15:29:57 +0200 Subject: [PATCH] BUG/MINOR: stconn: Fix sc_mux_strm() return value Since the begining, this function returns a pointer on an appctx while it should be a void pointer. It is the caller responsibility to cast it to the right type, the corresponding mux stream in this case. However, it is not a big deal because this function is unused for now. Only the unsafe one is used. This patch must be backported as far as 2.6. --- include/haproxy/stconn.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/haproxy/stconn.h b/include/haproxy/stconn.h index 2582ba38d..c28edc2c3 100644 --- a/include/haproxy/stconn.h +++ b/include/haproxy/stconn.h @@ -255,7 +255,7 @@ static inline void *__sc_mux_strm(const struct stconn *sc) { return __sc_endp(sc); } -static inline struct appctx *sc_mux_strm(const struct stconn *sc) +static inline void *sc_mux_strm(const struct stconn *sc) { if (sc_ep_test(sc, SE_FL_T_MUX)) return __sc_mux_strm(sc);