mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-08-07 23:56:57 +02:00
Code Issues Projects Releases Wiki Activity

BUG/MINOR: mux-h1/mux-fcgi: Sanitize TE header to only send "trailers"

Browse Source 
Only chunk-encoded response payloads are supported by HAProxy. All other
transfer encodings are not supported and will be an issue if the HTTP
compression is enabled. So be sure only "trailers" is send in TE request
headers.

The patch is related to the issue #1301. It must be backported to all stable
versions. Be carefull for 2.0 and lower because the HTTP legacy must also be
fixed.
This commit is contained in:
Christopher Faulet 2021-09-28 10:56:36 +02:00
parent 631c7e8665
commit f56e8465f0
2 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/mux_fcgi.c
View File

@ -2028,6 +2028,15 @@ static size_t fcgi_strm_send_params(struct fcgi_conn *fconn, struct fcgi_strm *f
else { else {
if (isteq(p.n, ist("host"))) if (isteq(p.n, ist("host")))
params.srv_name = p.v; params.srv_name = p.v;
else if (isteq(p.n, ist("te"))) {
/* "te" may only be sent with "trailers" if this value
* is present, otherwise it must be deleted.
*/
p.v = istist(p.v, ist("trailers"));
if (!isttest(p.v) || (p.v.len > 8 && p.v.ptr[8] != ','))
break;
p.v = ist("trailers");
}
/* Skip header if same name is used to add the server name */ /* Skip header if same name is used to add the server name */
if (fconn->proxy->server_id_hdr_name && if (fconn->proxy->server_id_hdr_name &&

9
src/mux_h1.c
View File

@ -1974,6 +1974,15 @@ static size_t h1_process_mux(struct h1c *h1c, struct buffer *buf, size_t count)
!(h1m->flags & H1_MF_RESP))) { !(h1m->flags & H1_MF_RESP))) {
ws_key_found = 1; ws_key_found = 1;
} }
else if (isteq(n, ist("te"))) {
/* "te" may only be sent with "trailers" if this value
* is present, otherwise it must be deleted.
*/
v = istist(v, ist("trailers"));
if (!isttest(v) || (v.len > 8 && v.ptr[8] != ','))
goto skip_hdr;
v = ist("trailers");
}
/* Skip header if same name is used to add the server name */ /* Skip header if same name is used to add the server name */
if (!(h1m->flags & H1_MF_RESP) && h1c->px->server_id_hdr_name && if (!(h1m->flags & H1_MF_RESP) && h1c->px->server_id_hdr_name &&