mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-09-20 21:31:28 +02:00
Code Issues Projects Releases Wiki Activity

BUG/MEDIUM: http: fix incorrect reporting of server errors

Browse Source 
Commit dbe34eb ("MEDIUM: filters/http: Move body parsing of HTTP
messages in dedicated functions") introduced a bug in function
http_response_forward_body() by getting rid of the while(1) loop.
The code immediately following the loop was only reachable on missing
data but now it's also reachable under normal conditions, which used
to be dealt with by the skip_resync_state label returning zero. The
side effect is that in http_server_close situations, the channel's
SHUTR flag is seen and considered as a server error which is reported
if any other error happens (eg: client timeout).

This bug is specific to 1.7, no backport is needed.
This commit is contained in:
Willy Tarreau 2016-05-02 15:25:15 +02:00
parent 54e439f0b4
commit f51d03cf14
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/proto_http.c
View File

@ -6709,6 +6709,7 @@ int http_response_forward_body(struct stream *s, struct channel *res, int an_bit
}
return 1;
}
return 0;
missing_data_or_waiting:
if (res->flags & CF_SHUTW)