mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-10-26 22:20:59 +01:00
Code Issues Projects Releases Wiki Activity

BUG/MINOR: pools: don't report "limited to the first X entries" by default

Browse Source 
With the fix in commit 982805e6a3 ("BUG/MINOR: pools: Fix the dump of
pools info to deal with buffers limitations"), the max count is now
compared to the number of dumped pools instead of the configured
numbered, and keeping >= is no longer valid because maxcnt is set by
default to the same value when not set, so this means that since this
patch we're always displaying "limited to the first X entries" where X
is the number of dumped entries even in the absence of any limitation.
Let's just fix the comparison to only show this when the limit is lower.

This must be backported to 3.2 where the patch above already is.
This commit is contained in:
Willy Tarreau 2025-10-16 08:38:35 +02:00
parent ab0c97139f
commit f263a45ddf
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/pool.c
View File

@ -1399,7 +1399,7 @@ int dump_pools_info(struct appctx *appctx)
if (ctx->pool_idx == -1) {
chunk_printf(&trash, "Dumping pools usage");
if (ctx->nbpools >= ctx->maxcnt)
if (ctx->nbpools > ctx->maxcnt)
chunk_appendf(&trash, " (limited to the first %u entries)", ctx->maxcnt);
chunk_appendf(&trash, ". Use SIGQUIT to flush them.\n");