From f0653192e31d3baa95ead5501b5cda467ab15b6d Mon Sep 17 00:00:00 2001 From: Andreas Seltenreich Date: Thu, 3 Mar 2016 20:08:35 +0100 Subject: [PATCH] CLEANUP: pattern: Ignore unknown samples in pat_match_ip(). Ignore samples that are neither SMP_T_IPV4 nor SMP_T_IPV6 instead of matching with an uninitialized value in this case. This situation should not occur in the current codebase but triggers warnings in static code analysis tools. Found in haproxy 1.5. --- src/pattern.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/pattern.c b/src/pattern.c index b4cb8e9ea..9d07b89c5 100644 --- a/src/pattern.c +++ b/src/pattern.c @@ -1021,6 +1021,9 @@ struct pattern *pat_match_ip(struct sample *smp, struct pattern_expr *expr, int } else continue; + } else { + /* impossible */ + continue; } /* Check if the input sample match the current pattern. */