mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-11-28 14:21:00 +01:00
Code Issues Projects Releases Wiki Activity

BUG/MINOR: quic: fix discarding of already stored out-of-order ACK

Browse Source 
To properly decount out-of-order acked data range, contiguous or
overlapping ranges are first merged before their insertion in a tree.

The first step ensure that a newly reported range is not completely
covered by the existing tree ranges. However, one of the condition was
incorrect. Fix this to ensure that the final range tree does not contain
duplicated entry.

The impact of this bug is unknown. However, it may have allowed the
insertion of overlapping ranges, which could in turn cause an error in
QUIC MUX txbuf window, with a possible transfer freeze.

No need to backport.
This commit is contained in:
Amaury Denoyelle 2024-10-09 12:03:36 +02:00
parent f88f162868
commit f0049d0748
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/quic_stream.c
View File

@ -178,7 +178,7 @@ static int qc_stream_buf_store_ack(struct qc_stream_buf *buf,
ack_less = eb64_entry(less, struct qc_stream_ack, offset_node);
/* Ensure that offset:len range has not been already acknowledged, at least partially. */
if ((ack_more && offset == ack_more->offset_node.key && offset + len <= ack_more->offset_node.key) ||
if ((ack_more && offset == ack_more->offset_node.key && offset + len <= ack_more->offset_node.key + ack_more->len) ||
(ack_less && ack_less->offset_node.key + ack_less->len >= offset + len)) {
newly_acked = 0;
goto end;