mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2026-02-05 01:11:51 +01:00
Code Issues Projects Releases Wiki Activity

BUG/MEDIUM: ssl: Don't forget to free ctx->ssl on failure.

Browse Source 
In ssl_sock_init(), if we fail to allocate the BIO, don't forget to free
the SSL *, or we'd end up with a memory leak.

This should be backported to 2.1 and 2.0.
This commit is contained in:
Olivier Houchard 2020-01-24 15:17:38 +01:00
parent 6d53cd6978
commit efe5e8e998
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/ssl_sock.c
View File

@ -5937,6 +5937,8 @@ static int ssl_sock_init(struct connection *conn, void **xprt_ctx)
}
ctx->bio = BIO_new(ha_meth);
if (!ctx->bio) {
SSL_free(ctx->ssl);
ctx->ssl = NULL;
if (may_retry--) {
pool_gc(NULL);
goto retry_connect;
@ -5999,6 +6001,8 @@ static int ssl_sock_init(struct connection *conn, void **xprt_ctx)
}
ctx->bio = BIO_new(ha_meth);
if (!ctx->bio) {
SSL_free(ctx->ssl);
ctx->ssl = NULL;
if (may_retry--) {
pool_gc(NULL);
goto retry_accept;