From ed3ed358676edf058663bde7ec6098b51f8bc745 Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Thu, 21 Nov 2024 11:30:03 +0100 Subject: [PATCH] BUG/MEDIUM: pools/memprofile: always clean stale pool info on pool_destroy() There's actually a problem with memprofiles: the pool pointer is stored in ->info but some pools are replaced during startup, such as the trash pool, leaving a dangling pointer there, that may randomly report crap or even crash during "show profile memory". Let's make pool_destroy() call memprof_remove_stale_info() added by previous patch so that these entries are properly unregistered. This must be backported along with the previous patch (MINOR: activity/memprofile: offer a function to unregister stale info) as far as 2.8. --- src/pool.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/pool.c b/src/pool.c index 31c5c2251..f4a4af100 100644 --- a/src/pool.c +++ b/src/pool.c @@ -946,6 +946,9 @@ void *pool_destroy(struct pool_head *pool) /* note that if used == 0, the cache is empty */ free(pool->base_addr); } + + /* make sure this pool is no longer referenced in memory profiling */ + memprof_remove_stale_info(pool); } return NULL; }