From ece3bf65ca29e914a2c3b2aad643a09e39bb77c3 Mon Sep 17 00:00:00 2001 From: Amaury Denoyelle Date: Fri, 6 Dec 2024 16:47:53 +0100 Subject: [PATCH] MINOR: mux-h1: use explicit __objt_server on idle conn reinsert When dealing with a backend connection, H1 mux IO handler must reinsert it in its idle list pool if it was extracted from it at the beginning. This is the case if conn_in_list is true. On reinsert, idle list pool is retrieved via the server instance accessible from . Replace objt_server usage with __objt_server as an idle connection is always attached to a server. This ensures that there is no issue when using _srv_add_idle() then. This should fix coverity report from github issue #2810. --- src/mux_h1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mux_h1.c b/src/mux_h1.c index 734d0627b..7eb18133d 100644 --- a/src/mux_h1.c +++ b/src/mux_h1.c @@ -4252,7 +4252,7 @@ struct task *h1_io_cb(struct task *t, void *ctx, unsigned int state) t = NULL; if (!ret && conn_in_list) { - struct server *srv = objt_server(conn->target); + struct server *srv = __objt_server(conn->target); HA_SPIN_LOCK(IDLE_CONNS_LOCK, &idle_conns[tid].idle_conns_lock); _srv_add_idle(srv, conn, conn_in_list == CO_FL_SAFE_LIST);