mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-09-22 06:11:32 +02:00
Code Issues Projects Releases Wiki Activity

BUG/MINOR: mux-h2: Use the dummy error when decoding headers for a closed stream

Browse Source 
Since the commit 6884aa3e ("BUG/MAJOR: mux-h2: Handle HEADERS frames received
after a RST_STREAM frame"), HEADERS frames received for an unknown or already
closed stream are decoded. Once decoded, an error is reported for the
stream. But because it is a dummy stream (h2_closed_stream), its state cannot be
changed. So instead, we must return the dummy error stream (h2_error_stream).

This patch must be backported to 2.0 and 1.9.
This commit is contained in:
Christopher Faulet 2019-09-26 16:19:13 +02:00
parent b2d930ebe6
commit ea7a7781a9
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/mux_h2.c
View File

@ -2518,7 +2518,7 @@ static struct h2s *h2c_bck_handle_headers(struct h2c *h2c, struct h2s *h2s)
* the data and send another RST. * the data and send another RST.
*/ */
error = h2c_decode_headers(h2c, &rxbuf, &flags, &body_len); error = h2c_decode_headers(h2c, &rxbuf, &flags, &body_len);
h2s_error(h2s, H2_ERR_STREAM_CLOSED); h2s = (struct h2s*)h2_error_stream;
h2c->st0 = H2_CS_FRAME_E; h2c->st0 = H2_CS_FRAME_E;
goto send_rst; goto send_rst;
} }