From ea3e0355dac6fdaa94f65ed46b553936f9add5bb Mon Sep 17 00:00:00 2001 From: Amaury Denoyelle Date: Mon, 21 Feb 2022 10:05:16 +0100 Subject: [PATCH] MINOR: mux-quic: fix a possible null dereference in qc_timeout_task The qcc instance should be tested as it is implied by a previous test that it may be NULL. In this case, qc_timeout_task can be stopped. This should fix github issue #1559. --- src/mux_quic.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/mux_quic.c b/src/mux_quic.c index 2ed269e3c..c01fcbfa7 100644 --- a/src/mux_quic.c +++ b/src/mux_quic.c @@ -427,6 +427,10 @@ static struct task *qc_timeout_task(struct task *t, void *ctx, unsigned int stat fprintf(stderr, "%s: timeout\n", __func__); task_destroy(t); + + if (!qcc) + return NULL; + qcc->task = NULL; if (qcc_is_dead(qcc))