From e6d0b87f7f18cd07163687f15b086eb86ed57957 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Fri, 29 Dec 2023 23:31:39 +0100 Subject: [PATCH] CI: use semantic version compare for determing "latest" OpenSSL currently "openssl-3.2.0-beta1" wins over "openssl-3.2.0" due to string comparision. let's switch to semantic version compare --- .github/matrix.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/matrix.py b/.github/matrix.py index d5ad6931a..5e01c28bb 100755 --- a/.github/matrix.py +++ b/.github/matrix.py @@ -14,6 +14,7 @@ import re import sys import urllib.request from os import environ +from packaging import version # # this CI is used for both development and stable branches of HAProxy @@ -47,7 +48,7 @@ def determine_latest_openssl(ssl): latest_tag = "" for tag in tags: if "openssl-" in tag: - if tag > latest_tag: + if (not latest_tag) or (version.parse(tag[8:]) > version.parse(latest_tag[8:])): latest_tag = tag return "OPENSSL_VERSION={}".format(latest_tag[8:])