From e44989369d819d20edeb6bc2ea40a4c3a512610e Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Mon, 22 Mar 2021 21:13:05 +0100 Subject: [PATCH] CLEANUP: quic: use pool_zalloc() instead of pool_alloc+memset Two places used to alloc then zero the area, let's have the allocator do it. --- src/xprt_quic.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/xprt_quic.c b/src/xprt_quic.c index be15af90d..f57506ffd 100644 --- a/src/xprt_quic.c +++ b/src/xprt_quic.c @@ -2322,9 +2322,8 @@ struct quic_conn *new_quic_conn(uint32_t version) { struct quic_conn *quic_conn; - quic_conn = pool_alloc(pool_head_quic_conn); + quic_conn = pool_zalloc(pool_head_quic_conn); if (quic_conn) { - memset(quic_conn, 0, sizeof *quic_conn); quic_conn->version = version; } @@ -4217,11 +4216,10 @@ static ssize_t quic_dgram_read(char *buf, size_t len, void *owner, int ret; struct quic_rx_packet *pkt; - pkt = pool_alloc(pool_head_quic_rx_packet); + pkt = pool_zalloc(pool_head_quic_rx_packet); if (!pkt) goto err; - memset(pkt, 0, sizeof(*pkt)); quic_rx_packet_refinc(pkt); ret = func(&pos, end, pkt, &dgram_ctx, saddr); if (ret == -1) {