From e3d5f9a92b5c1f0affac677f7ef9b8f030dbb64b Mon Sep 17 00:00:00 2001 From: Remi Tricot-Le Breton Date: Thu, 15 Dec 2022 15:44:36 +0100 Subject: [PATCH] MINOR: ssl: Remove unnecessary alloc'ed trash chunk in show ocsp-response When displaying the content of an OCSP response in the CLI, a buffer is alloc'ed when a temporary buffer would be enough. --- src/ssl_sock.c | 22 +++++----------------- 1 file changed, 5 insertions(+), 17 deletions(-) diff --git a/src/ssl_sock.c b/src/ssl_sock.c index 9c08c6011..65d0c857d 100644 --- a/src/ssl_sock.c +++ b/src/ssl_sock.c @@ -7921,30 +7921,18 @@ int ssl_get_ocspresponse_detail(unsigned char *ocsp_certid, struct buffer *out) */ static int cli_io_handler_show_ocspresponse_detail(struct appctx *appctx) { - struct buffer *trash = alloc_trash_chunk(); + struct buffer *trash = get_trash_chunk(); struct certificate_ocsp *ocsp = appctx->svcctx; - if (trash == NULL) - return 1; - - if (ssl_ocsp_response_print(&ocsp->response, trash)) { - free_trash_chunk(trash); - return 1; - } + if (ssl_ocsp_response_print(&ocsp->response, trash)) + goto end; if (applet_putchk(appctx, trash) == -1) - goto yield; + return 0; +end: appctx->svcctx = NULL; - if (trash) - free_trash_chunk(trash); return 1; - -yield: - if (trash) - free_trash_chunk(trash); - - return 0; } #endif