From de41121c0c32503cf557b0c0ae96ba91d691c053 Mon Sep 17 00:00:00 2001 From: Miroslav Zagorac Date: Fri, 26 Sep 2025 00:13:12 +0200 Subject: [PATCH] CLEANUP: ot: use the item API for the variables trees In flt_ot_vars_scope_dump(), switched from cebu64_first()/cebu64_next() to cebu64_imm_first()/cebu64_imm_next() for iterating the variable name trees. Since this function only reads variables under a read lock, the immutable traversal API is the correct choice. Also updated the container_of() member from 'node' to 'name_node' to match the current struct var layout. --- addons/ot/src/vars.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/addons/ot/src/vars.c b/addons/ot/src/vars.c index 5030bc412..e0c6923c4 100644 --- a/addons/ot/src/vars.c +++ b/addons/ot/src/vars.c @@ -46,10 +46,10 @@ static void flt_ot_vars_scope_dump(struct vars *vars, const char *scope) vars_rdlock(vars); for (i = 0; i < VAR_NAME_ROOTS; i++) { - struct ceb_node *node = cebu64_first(&(vars->name_root[i])); + struct ceb_node *node = cebu64_imm_first(&(vars->name_root[i])); - for ( ; node != NULL; node = cebu64_next(&(vars->name_root[i]), node)) { - struct var *var = container_of(node, struct var, node); + for ( ; node != NULL; node = cebu64_imm_next(&(vars->name_root[i]), node)) { + struct var *var = container_of(node, struct var, name_node); FLT_OT_DBG(2, "'%s.%016" PRIx64 "' -> '%.*s'", scope, var->name_hash, (int)b_data(&(var->data.u.str)), b_orig(&(var->data.u.str))); }