mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-08-10 09:07:02 +02:00
Code Issues Projects Releases Wiki Activity

[STATS] report the number of times each server was selected

Browse Source 
One user reported that an indicator was missing in the statistics:
the number of times each server was selected by load balancing. It
is in fact the total number of sessions assigned to a server by the
load balancing algorithm. It should directly reflect the weight for
"fair" algorithms such as round-robin, since it will not account for
persistant connections.

It should help a lot tuning each server's weight depending on the
load it receives.
This commit is contained in:
Willy Tarreau 2007-12-05 10:34:49 +01:00
parent 5542af65dc
commit ddbb82ff47
4 changed files with 31 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
include/types/proxy.h
View File

@ -184,6 +184,7 @@ struct proxy {
unsigned int feconn, feconn_max; /* # of active frontend sessions */ unsigned int feconn, feconn_max; /* # of active frontend sessions */
unsigned int beconn, beconn_max; /* # of active backend sessions */ unsigned int beconn, beconn_max; /* # of active backend sessions */
unsigned int cum_feconn, cum_beconn; /* cumulated number of processed sessions */ unsigned int cum_feconn, cum_beconn; /* cumulated number of processed sessions */
unsigned int cum_lbconn; /* cumulated number of sessions processed by load balancing */
unsigned int maxconn; /* max # of active sessions on the frontend */ unsigned int maxconn; /* max # of active sessions on the frontend */
unsigned int fullconn; /* #conns on backend above which servers are used at full load */ unsigned int fullconn; /* #conns on backend above which servers are used at full load */
struct in_addr except_net, except_mask; /* don't x-forward-for for this address. FIXME: should support IPv6 */ struct in_addr except_net, except_mask; /* don't x-forward-for for this address. FIXME: should support IPv6 */

1
include/types/server.h
View File

@ -116,6 +116,7 @@ struct server {
unsigned retries; /* retried connections */ unsigned retries; /* retried connections */
unsigned failed_secu; /* blocked responses because of security concerns */ unsigned failed_secu; /* blocked responses because of security concerns */
unsigned cum_sess; /* cumulated number of sessions really sent to this server */ unsigned cum_sess; /* cumulated number of sessions really sent to this server */
unsigned cum_lbconn; /* cumulated number of sessions directed by load balancing */
long long bytes_in; /* number of bytes transferred from the client to the server */ long long bytes_in; /* number of bytes transferred from the client to the server */
long long bytes_out; /* number of bytes transferred from the server to the client */ long long bytes_out; /* number of bytes transferred from the server to the client */

2
src/backend.c
View File

@ -955,6 +955,8 @@ int assign_server(struct session *s)
/* unknown balancing algorithm */ /* unknown balancing algorithm */
return SRV_STATUS_INTERNAL; return SRV_STATUS_INTERNAL;
} }
s->be->cum_lbconn++;
s->srv->cum_lbconn++;
} }
else if (s->be->options & PR_O_HTTP_PROXY) { else if (s->be->options & PR_O_HTTP_PROXY) {
if (!s->srv_addr.sin_addr.s_addr) if (!s->srv_addr.sin_addr.s_addr)

46
src/dumpstats.c
View File

@ -171,7 +171,7 @@ int print_csv_header(struct chunk *msg, int size)
"wretr,wredis," "wretr,wredis,"
"status,weight,act,bck," "status,weight,act,bck,"
"chkfail,chkdown,lastchg,downtime,qlimit," "chkfail,chkdown,lastchg,downtime,qlimit,"
"pid,iid,sid,throttle," "pid,iid,sid,throttle,lbtot,"
"\n"); "\n");
} }
@ -589,21 +589,21 @@ int stats_dump_proxy(struct session *s, struct proxy *px, struct uri_auth *uri,
if (flags & STAT_FMT_HTML) { if (flags & STAT_FMT_HTML) {
/* print a new table */ /* print a new table */
chunk_printf(&msg, sizeof(trash), chunk_printf(&msg, sizeof(trash),
"<table cols=\"25\" class=\"tbl\" width=\"100%%\">\n" "<table cols=\"26\" class=\"tbl\" width=\"100%%\">\n"
"<tr align=\"center\" class=\"titre\">" "<tr align=\"center\" class=\"titre\">"
"<th colspan=2 class=\"pxname\">%s</th>" "<th colspan=2 class=\"pxname\">%s</th>"
"<th colspan=22 class=\"empty\"></th>" "<th colspan=24 class=\"empty\"></th>"
"</tr>\n" "</tr>\n"
"<tr align=\"center\" class=\"titre\">" "<tr align=\"center\" class=\"titre\">"
"<th rowspan=2></th>" "<th rowspan=2></th>"
"<th colspan=3>Queue</th><th colspan=4>Sessions</th>" "<th colspan=3>Queue</th><th colspan=5>Sessions</th>"
"<th colspan=2>Bytes</th><th colspan=2>Denied</th>" "<th colspan=2>Bytes</th><th colspan=2>Denied</th>"
"<th colspan=3>Errors</th><th colspan=2>Warnings</th>" "<th colspan=3>Errors</th><th colspan=2>Warnings</th>"
"<th colspan=8>Server</th>" "<th colspan=8>Server</th>"
"</tr>\n" "</tr>\n"
"<tr align=\"center\" class=\"titre\">" "<tr align=\"center\" class=\"titre\">"
"<th>Cur</th><th>Max</th><th>Limit</th><th>Cur</th><th>Max</th>" "<th>Cur</th><th>Max</th><th>Limit</th><th>Cur</th><th>Max</th>"
"<th>Limit</th><th>Cumul</th><th>In</th><th>Out</th>" "<th>Limit</th><th>Total</th><th>LbTot</th><th>In</th><th>Out</th>"
"<th>Req</th><th>Resp</th><th>Req</th><th>Conn</th>" "<th>Req</th><th>Resp</th><th>Req</th><th>Conn</th>"
"<th>Resp</th><th>Retr</th><th>Redis</th>" "<th>Resp</th><th>Retr</th><th>Redis</th>"
"<th>Status</th><th>Wght</th><th>Act</th>" "<th>Status</th><th>Wght</th><th>Act</th>"
@ -626,9 +626,10 @@ int stats_dump_proxy(struct session *s, struct proxy *px, struct uri_auth *uri,
chunk_printf(&msg, sizeof(trash), chunk_printf(&msg, sizeof(trash),
/* name, queue */ /* name, queue */
"<tr align=center class=\"frontend\"><td>Frontend</td><td colspan=3></td>" "<tr align=center class=\"frontend\"><td>Frontend</td><td colspan=3></td>"
/* sessions : current, max, limit, cumul */ /* sessions : current, max, limit, total, lbtot */
"<td align=right>%d</td><td align=right>%d</td>" "<td align=right>%d</td><td align=right>%d</td>"
"<td align=right>%d</td><td align=right>%d</td>" "<td align=right>%d</td><td align=right>%d</td>"
"<td align=right></td>"
/* bytes : in, out */ /* bytes : in, out */
"<td align=right>%lld</td><td align=right>%lld</td>" "<td align=right>%lld</td><td align=right>%lld</td>"
/* denied: req, resp */ /* denied: req, resp */
@ -652,7 +653,7 @@ int stats_dump_proxy(struct session *s, struct proxy *px, struct uri_auth *uri,
chunk_printf(&msg, sizeof(trash), chunk_printf(&msg, sizeof(trash),
/* pxid, name, queue cur, queue max, */ /* pxid, name, queue cur, queue max, */
"%s,FRONTEND,,," "%s,FRONTEND,,,"
/* sessions : current, max, limit, cumul */ /* sessions : current, max, limit, total */
"%d,%d,%d,%d," "%d,%d,%d,%d,"
/* bytes : in, out */ /* bytes : in, out */
"%lld,%lld," "%lld,%lld,"
@ -666,8 +667,8 @@ int stats_dump_proxy(struct session *s, struct proxy *px, struct uri_auth *uri,
"%s," "%s,"
/* rest of server: nothing */ /* rest of server: nothing */
",,,,,,,," ",,,,,,,,"
/* pid, iid, sid, throttle, */ /* pid, iid, sid, throttle, lbtot, */
"%d,%d,0,," "%d,%d,0,,,"
"\n", "\n",
px->id, px->id,
px->feconn, px->feconn_max, px->maxconn, px->cum_feconn, px->feconn, px->feconn_max, px->maxconn, px->cum_feconn,
@ -728,9 +729,10 @@ int stats_dump_proxy(struct session *s, struct proxy *px, struct uri_auth *uri,
"<tr align=\"center\" class=\"%s%d\"><td>%s</td>" "<tr align=\"center\" class=\"%s%d\"><td>%s</td>"
/* queue : current, max, limit */ /* queue : current, max, limit */
"<td align=right>%d</td><td align=right>%d</td><td align=right>%s</td>" "<td align=right>%d</td><td align=right>%d</td><td align=right>%s</td>"
/* sessions : current, max, limit, cumul */ /* sessions : current, max, limit, total, lbtot */
"<td align=right>%d</td><td align=right>%d</td>" "<td align=right>%d</td><td align=right>%d</td>"
"<td align=right>%s</td><td align=right>%d</td>" "<td align=right>%s</td><td align=right>%d</td>"
"<td align=right>%d</td>"
/* bytes : in, out */ /* bytes : in, out */
"<td align=right>%lld</td><td align=right>%lld</td>" "<td align=right>%lld</td><td align=right>%lld</td>"
/* denied: req, resp */ /* denied: req, resp */
@ -743,7 +745,8 @@ int stats_dump_proxy(struct session *s, struct proxy *px, struct uri_auth *uri,
(sv->state & SRV_BACKUP) ? "backup" : "active", (sv->state & SRV_BACKUP) ? "backup" : "active",
sv_state, sv->id, sv_state, sv->id,
sv->nbpend, sv->nbpend_max, LIM2A0(sv->maxqueue, "-"), sv->nbpend, sv->nbpend_max, LIM2A0(sv->maxqueue, "-"),
sv->cur_sess, sv->cur_sess_max, LIM2A1(sv->maxconn, "-"), sv->cum_sess, sv->cur_sess, sv->cur_sess_max, LIM2A1(sv->maxconn, "-"),
sv->cum_sess, sv->cum_lbconn,
sv->bytes_in, sv->bytes_out, sv->bytes_in, sv->bytes_out,
sv->failed_secu, sv->failed_secu,
sv->failed_conns, sv->failed_resp, sv->failed_conns, sv->failed_resp,
@ -805,7 +808,7 @@ int stats_dump_proxy(struct session *s, struct proxy *px, struct uri_auth *uri,
"%s,%s," "%s,%s,"
/* queue : current, max */ /* queue : current, max */
"%d,%d," "%d,%d,"
/* sessions : current, max, limit, cumul */ /* sessions : current, max, limit, total */
"%d,%d,%s,%d," "%d,%d,%s,%d,"
/* bytes : in, out */ /* bytes : in, out */
"%lld,%lld," "%lld,%lld,"
@ -864,6 +867,8 @@ int stats_dump_proxy(struct session *s, struct proxy *px, struct uri_auth *uri,
chunk_printf(&msg, sizeof(trash), "%d", ratio); chunk_printf(&msg, sizeof(trash), "%d", ratio);
} }
/* sessions: lbtot */
chunk_printf(&msg, sizeof(trash), ",%d", sv->cum_lbconn);
/* ',' then EOL */ /* ',' then EOL */
chunk_printf(&msg, sizeof(trash), ",\n"); chunk_printf(&msg, sizeof(trash), ",\n");
} }
@ -885,8 +890,10 @@ int stats_dump_proxy(struct session *s, struct proxy *px, struct uri_auth *uri,
"<tr align=center class=\"backend\"><td>Backend</td>" "<tr align=center class=\"backend\"><td>Backend</td>"
/* queue : current, max */ /* queue : current, max */
"<td align=right>%d</td><td align=right>%d</td><td></td>" "<td align=right>%d</td><td align=right>%d</td><td></td>"
/* sessions : current, max, limit, cumul. */ /* sessions : current, max, limit, total, lbtot */
"<td align=right>%d</td><td align=right>%d</td><td align=right>%d</td><td align=right>%d</td>" "<td align=right>%d</td><td align=right>%d</td>"
"<td align=right>%d</td><td align=right>%d</td>"
"<td align=right>%d</td>"
/* bytes : in, out */ /* bytes : in, out */
"<td align=right>%lld</td><td align=right>%lld</td>" "<td align=right>%lld</td><td align=right>%lld</td>"
/* denied: req, resp */ /* denied: req, resp */
@ -902,7 +909,7 @@ int stats_dump_proxy(struct session *s, struct proxy *px, struct uri_auth *uri,
"<td align=center nowrap>%s %s</td><td align=center>%d</td>" "<td align=center nowrap>%s %s</td><td align=center>%d</td>"
"<td align=center>%d</td><td align=center>%d</td>", "<td align=center>%d</td><td align=center>%d</td>",
px->nbpend /* or px->totpend ? */, px->nbpend_max, px->nbpend /* or px->totpend ? */, px->nbpend_max,
px->beconn, px->beconn_max, px->fullconn, px->cum_beconn, px->beconn, px->beconn_max, px->fullconn, px->cum_beconn, px->cum_lbconn,
px->bytes_in, px->bytes_out, px->bytes_in, px->bytes_out,
px->denied_req, px->denied_resp, px->denied_req, px->denied_resp,
px->failed_conns, px->failed_resp, px->failed_conns, px->failed_resp,
@ -927,7 +934,7 @@ int stats_dump_proxy(struct session *s, struct proxy *px, struct uri_auth *uri,
"%s,BACKEND," "%s,BACKEND,"
/* queue : current, max */ /* queue : current, max */
"%d,%d," "%d,%d,"
/* sessions : current, max, limit, cumul */ /* sessions : current, max, limit, total */
"%d,%d,%d,%d," "%d,%d,%d,%d,"
/* bytes : in, out */ /* bytes : in, out */
"%lld,%lld," "%lld,%lld,"
@ -945,8 +952,8 @@ int stats_dump_proxy(struct session *s, struct proxy *px, struct uri_auth *uri,
"%d,%d,%d," "%d,%d,%d,"
/* rest of backend: nothing, down transitions, last change, total downtime */ /* rest of backend: nothing, down transitions, last change, total downtime */
",%d,%d,%d,," ",%d,%d,%d,,"
/* pid, iid, sid, throttle, */ /* pid, iid, sid, throttle, lbtot, */
"%d,%d,0,," "%d,%d,0,,%d,"
"\n", "\n",
px->id, px->id,
px->nbpend /* or px->totpend ? */, px->nbpend_max, px->nbpend /* or px->totpend ? */, px->nbpend_max,
@ -960,7 +967,8 @@ int stats_dump_proxy(struct session *s, struct proxy *px, struct uri_auth *uri,
px->srv_act, px->srv_bck, px->srv_act, px->srv_bck,
px->down_trans, now.tv_sec - px->last_change, px->down_trans, now.tv_sec - px->last_change,
px->srv?be_downtime(px):0, px->srv?be_downtime(px):0,
relative_pid, px->uuid); relative_pid, px->uuid,
px->cum_lbconn);
} }
if (buffer_write_chunk(rep, &msg) != 0) if (buffer_write_chunk(rep, &msg) != 0)
return 0; return 0;