From dc66f2f97d76613d732c49cc326791863b018f0e Mon Sep 17 00:00:00 2001 From: William Lallemand Date: Tue, 26 Jul 2022 10:35:24 +0200 Subject: [PATCH] DEBUG: fd: split the fd check Split the BUG_ON(fd < 0 || fd >= global.maxsock) so it's easier to know if it quits because of a -1. --- include/haproxy/fd.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/haproxy/fd.h b/include/haproxy/fd.h index e8ef4f3bc..8925efb66 100644 --- a/include/haproxy/fd.h +++ b/include/haproxy/fd.h @@ -433,7 +433,8 @@ static inline void fd_insert(int fd, void *owner, void (*iocb)(int fd), int tgid /* This must never happen and would definitely indicate a bug, in * addition to overwriting some unexpected memory areas. */ - BUG_ON(fd < 0 || fd >= global.maxsock); + BUG_ON(fd < 0); + BUG_ON(fd >= global.maxsock); BUG_ON(fdtab[fd].owner != NULL); BUG_ON(fdtab[fd].state != 0); BUG_ON(tgid < 1 || tgid > MAX_TGROUPS);