mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-12-15 22:51:00 +01:00
Code Issues Projects Releases Wiki Activity

MINOR: threads: Define the sync-point inside run_poll_loop

Browse Source 
The function sync_poll_loop is called at the end of each loop inside
run_poll_loop function. It is a protected area where all threads have a chance
to execute tricky tasks with the warranty that no concurrent access is
possible. Of course, it comes with a cost because all threads must be
syncrhonized. So changes must be uncommon.
This commit is contained in:
Christopher Faulet 2017-10-19 11:59:44 +02:00 committed by Willy Tarreau
parent 1d17c10d8b
commit dc628a3a76
1 changed files with 26 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/haproxy.c
View File

@ -2203,6 +2203,26 @@ void deinit(void)
} /* end deinit() */
static void sync_poll_loop()
{
if (THREAD_NO_SYNC())
return;
THREAD_ENTER_SYNC();
if (!THREAD_NEED_SYNC())
goto exit;
/* *** { */
/* Put here all sync functions */
/* *** } */
exit:
THREAD_EXIT_SYNC();
}
/* Runs the polling loop */
static void run_poll_loop()
{
@ -2234,6 +2254,10 @@ static void run_poll_loop()
/* Commit server status changes */
servers_update_status();
/* Synchronize all polling loops */
sync_poll_loop();
}
}
@ -2254,6 +2278,7 @@ static void *run_thread_poll_loop(void *data)
}
}
THREAD_SYNC_ENABLE();
run_poll_loop();
list_for_each_entry(ptdf, &per_thread_deinit_list, list)
@ -2787,6 +2812,7 @@ int main(int argc, char **argv)
pthread_t *threads = calloc(global.nbthread, sizeof(pthread_t));
int i;
THREAD_SYNC_INIT((1UL << global.nbthread) - 1);
for (i = 0; i < global.nbthread; i++) {
tids[i] = i;
pthread_create(&threads[i], NULL, &run_thread_poll_loop, &tids[i]);