From db97bb42d9b435846809a028dce077eea1621b40 Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Tue, 8 Aug 2023 15:27:02 +0200 Subject: [PATCH] MINOR: mux-h2/traces: also suggest invalid header upon parsing error Historically the parsing error used to apply only to too large headers, so this is what has been reported in traces. But nowadays we can also reject invalid characters, and when this happens the trace is a bit misleading, so let's mention "or invalid". --- src/mux_h2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mux_h2.c b/src/mux_h2.c index 4120e0040..63b9a805c 100644 --- a/src/mux_h2.c +++ b/src/mux_h2.c @@ -4940,7 +4940,7 @@ next_frame: if (outlen < 0 || htx_free_space(htx) < global.tune.maxrewrite) { /* too large headers? this is a stream error only */ - TRACE_STATE("message headers too large", H2_EV_RX_FRAME|H2_EV_RX_HDR|H2_EV_H2S_ERR|H2_EV_PROTO_ERR, h2c->conn); + TRACE_STATE("message headers too large or invalid", H2_EV_RX_FRAME|H2_EV_RX_HDR|H2_EV_H2S_ERR|H2_EV_PROTO_ERR, h2c->conn); htx->flags |= HTX_FL_PARSING_ERROR; goto fail; }