mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2026-05-04 12:41:00 +02:00
Code Issues Projects Releases Wiki Activity

CLEANUP: resolvers: Perform unsafe loop on requester list when possible

Browse Source 
When answer list of a response is checked, it is useless to perform a safe
loop on the requester list.
This commit is contained in:
Christopher Faulet 2021-03-11 18:19:41 +01:00
parent c392d461d6
commit db31b4486c
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/resolvers.c
View File

@ -573,7 +573,7 @@ int resolv_read_name(unsigned char *buffer, unsigned char *bufend,
static void resolv_check_response(struct resolv_resolution *res)
{
struct resolvers *resolvers = res->resolvers;
struct resolv_requester *req, *reqback;
struct resolv_requester *req;
struct resolv_answer_item *item, *itemback;
struct server *srv;
struct resolv_srvrq *srvrq;
@ -595,7 +595,7 @@ static void resolv_check_response(struct resolv_resolution *res)
if (item->type != DNS_RTYPE_SRV)
goto rm_obselete_item;
list_for_each_entry_safe(req, reqback, &res->requesters, list) {
list_for_each_entry(req, &res->requesters, list) {
if ((srvrq = objt_resolv_srvrq(req->owner)) == NULL)
continue;
@ -631,7 +631,7 @@ static void resolv_check_response(struct resolv_resolution *res)
continue;
/* Now process SRV records */
list_for_each_entry_safe(req, reqback, &res->requesters, list) {
list_for_each_entry(req, &res->requesters, list) {
if ((srvrq = objt_resolv_srvrq(req->owner)) == NULL)
continue;