mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2026-05-04 12:41:00 +02:00
Code Issues Projects Releases Wiki Activity

BUG/MINOR: proto_ux: report correct error when bind_listener fails

Browse Source 
In uxst_bind_listener() and uxdg_bind_listener(), when the function
fails because the listener is not bound, both function are setting
the error message but don't set the err status before returning.

Because of this, such error is not properly handled by the upper functions.

Making sure this error is properly catched by returning a composition of
ERR_FATAL and ERR_ALERT.

This could be backported up to 2.4.
This commit is contained in:
Aurelien DARRAGON 2023-02-06 18:50:51 +01:00 committed by Christopher Faulet
parent 2bf99123ef
commit d861dc9b48
2 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/proto_uxdg.c
View File

@ -95,6 +95,7 @@ int uxdg_bind_listener(struct listener *listener, char *errmsg, int errlen)
if (!(listener->rx.flags & RX_F_BOUND)) {
msg = "receiving socket not bound";
err |= ERR_FATAL | ERR_ALERT;
goto uxdg_return;
}

1
src/proto_uxst.c
View File

@ -119,6 +119,7 @@ static int uxst_bind_listener(struct listener *listener, char *errmsg, int errle
if (!(listener->rx.flags & RX_F_BOUND)) {
msg = "receiving socket not bound";
err |= ERR_FATAL | ERR_ALERT;
goto uxst_return;
}