From d817e468bf77d1bd14ba99e7a6a28005d3945008 Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Fri, 23 Jan 2015 20:23:17 +0100 Subject: [PATCH] BUG/MINOR: sample: fix case sensitivity for the regsub converter Two commits ago in 7eda849 ("MEDIUM: samples: add a regsub converter to perform regex-based transformations"), I got caught for the second time with the inverted case sensitivity usage of regex_comp(). So by default it is case insensitive and passing the "i" flag makes it case sensitive. I forgot to recheck that case before committing the cleanup. No harm anyway, nobody had the time to use it. --- src/sample.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sample.c b/src/sample.c index 598bb533e..a1c6b4606 100644 --- a/src/sample.c +++ b/src/sample.c @@ -1201,7 +1201,7 @@ int smp_resolve_args(struct proxy *p) rflags |= (arg->type_flags & ARGF_REG_ICASE) ? REG_ICASE : 0; err = NULL; - if (!regex_comp(arg->data.str.str, reg, rflags, 1 /* capture substr */, &err)) { + if (!regex_comp(arg->data.str.str, reg, !(rflags & REG_ICASE), 1 /* capture substr */, &err)) { Alert("parsing [%s:%d] : error in regex '%s' in arg %d of %s%s%s%s '%s' %s proxy '%s' : %s.\n", cur->file, cur->line, arg->data.str.str,