mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-12-22 18:11:21 +01:00
Code Issues Projects Releases Wiki Activity

CLEANUP: tcpcheck: Remove useless test on the xprt used for healthchecks

Browse Source 
The xprt used to perform a healthcheck is always defined and cannot be NULL.
So there is no reason to test it. It could lead to wrong assumptions later
in the code.

This patch should fix a Coverity report from #3213.
This commit is contained in:
Christopher Faulet 2025-12-15 08:01:20 +01:00
parent 5c5914c32e
commit d6b1d5f6e9
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/tcpcheck.c
View File

@ -1462,7 +1462,7 @@ enum tcpcheck_eval_ret tcpcheck_eval_connect(struct check *check, struct tcpchec
: ((connect->options & TCPCHK_OPT_DEFAULT_CONNECT) ? check->xprt : xprt_get(XPRT_RAW))); : ((connect->options & TCPCHK_OPT_DEFAULT_CONNECT) ? check->xprt : xprt_get(XPRT_RAW)));
#ifdef USE_OPENSSL #ifdef USE_OPENSSL
if (xprt && xprt->get_ssl_sock_ctx) { if (xprt->get_ssl_sock_ctx) {
if (connect->sni) if (connect->sni)
sni = ist(connect->sni); sni = ist(connect->sni);
else if ((connect->options & TCPCHK_OPT_DEFAULT_CONNECT) && s && s->check.sni) else if ((connect->options & TCPCHK_OPT_DEFAULT_CONNECT) && s && s->check.sni)