mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-10-26 14:10:59 +01:00
Code Issues Projects Releases Wiki Activity

MINOR: config: remove experimental status on tune.disable-fast-forward

Browse Source 
The option was turned to off by default in 2.8 with commit 2f7c82bfd
("BUG/MINOR: haproxy: Fix option to disable the fast-forward"), however
at the same time it should have dropped its experimental status since
the feature is enabled by default. The only goal of the option is to
debug something, like many other tune.xxx options. The option should
still normally not be used without being invited to do so by developers
looking for something specific though.

This could be backported if desired to simplify debugging, though this
has never been needed for now.
This commit is contained in:
Willy Tarreau 2025-10-17 18:55:03 +02:00
parent e7c8deb810
commit d3881e61ac
2 changed files with 2 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
doc/configuration.txt
View File

@ -3996,16 +3996,14 @@ tune.comp.maxlevel <number>
Each stream using compression initializes the compression algorithm with
this value. The default value is 1.
tune.disable-fast-forward [ EXPERIMENTAL ]
tune.disable-fast-forward
Disables the data fast-forwarding. It is a mechanism to optimize the data
forwarding by passing data directly from a side to the other one without
waking the stream up. Thanks to this directive, it is possible to disable
this optimization. Note it also disable any kernel tcp splicing but also the
zero-copy forwarding. This command is not meant for regular use, it will
generally only be suggested by developers along complex debugging
sessions. For this reason it is internally marked as experimental, meaning
that "expose-experimental-directives" must appear on a line before this
directive.
sessions.
tune.disable-zero-copy-forwarding
Globally disables the zero-copy forwarding of data. It is a mechanism to

6
src/cfgparse-global.c
View File

@ -1473,12 +1473,6 @@ static int cfg_parse_global_tune_forward_opts(char **args, int section_type,
return -1;
if (strcmp(args[0], "tune.disable-fast-forward") == 0) {
if (!experimental_directives_allowed) {
memprintf(err, "'%s' directive is experimental, must be allowed via a global 'expose-experimental-directives'",
args[0]);
return -1;
}
mark_tainted(TAINTED_CONFIG_EXP_KW_DECLARED);
global.tune.options &= ~GTUNE_USE_FAST_FWD;
}
else if (strcmp(args[0], "tune.disable-zero-copy-forwarding") == 0) {