mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2026-02-15 14:21:08 +01:00
Code Issues Projects Releases Wiki Activity

[BUG] http: disable auto-closing during chunk analysis

Browse Source 
It may happen that we forward a close just after we sent the last
chunk, because we forgot to clear the AUTO_CLOSE flag.

This issue caused some pages to be truncated depending on some
timing races. Issue initially reported by Cyril Bont.
This commit is contained in:
Willy Tarreau 2010-01-04 02:02:25 +01:00
parent 1f44589b71
commit d3347ee227
1 changed files with 10 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/proto_http.c
View File

@ -3295,6 +3295,7 @@ int http_request_forward_body(struct session *s, struct buffer *req, int an_bit)
return 1;
}
buffer_dont_close(req);
if (unlikely(msg->msg_state < HTTP_MSG_BODY))
return 0;
@ -3359,12 +3360,10 @@ int http_request_forward_body(struct session *s, struct buffer *req, int an_bit)
/* we want the CRLF after the data */
int ret;
if (!(req->flags & BF_OUT_EMPTY))
return 0;
/* The output pointer does not move anymore, next unsent data
* are available at ->w. Let's save that.
*/
req->lr = req->w;
req->lr = req->w + req->send_max;
if (req->lr >= req->data + req->size)
req->lr -= req->size;
ret = http_skip_chunk_crlf(req, msg);
if (ret == 0)
@ -4407,6 +4406,7 @@ int http_response_forward_body(struct session *s, struct buffer *res, int an_bit
return 1;
}
buffer_dont_close(res);
if (unlikely(msg->msg_state < HTTP_MSG_BODY))
return 0;
@ -4468,12 +4468,10 @@ int http_response_forward_body(struct session *s, struct buffer *res, int an_bit
/* we want the CRLF after the data */
int ret;
if (!(res->flags & BF_OUT_EMPTY))
return 0;
/* The output pointer does not move anymore, next unsent data
* are available at ->w. Let's save that.
*/
res->lr = res->w;
res->lr = res->w + res->send_max;
if (res->lr >= res->data + res->size)
res->lr -= res->size;
ret = http_skip_chunk_crlf(res, msg);
if (!ret)