BUG/MINOR: h3: disable fast-forward on buffer alloc failure

If QCS Tx buffer cannot be allocated in nego_ff callback, disable
fast-forward for this connection and return immediately. If snd_buf is
later finally used but still no buffer can being allocated, the
connection will be closed on error.

This should fix coverity reported in github issue #2390.

This should be backported up to 2.9.
This commit is contained in:
Amaury Denoyelle 2023-12-22 16:07:10 +01:00
parent 2144d24186
commit cfa6d4cdd0

View File

@ -2012,7 +2012,8 @@ static size_t h3_nego_ff(struct qcs *qcs, size_t count)
h3_debug_printf(stderr, "%s\n", __func__);
if (!(res = qcc_get_stream_txbuf(qcs))) {
/* TODO */
qcs->sd->iobuf.flags |= IOBUF_FL_NO_FF;
goto end;
}
/* h3 DATA headers : 1-byte frame type + varint frame length */