mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-08-10 00:57:02 +02:00
Code Issues Projects Releases Wiki Activity

MINOR: http: check the source address via conn_get_src() in sample fetch functions

Browse Source 
In smp_fetch_url32_src() and smp_fetch_base32_src() it's better to
validate that the source address was properly initialized since it
will soon be dynamic, thus let's call conn_get_src().
This commit is contained in:
Willy Tarreau 2019-07-17 16:57:03 +02:00
parent 428d8e32f4
commit cd7ca79e6c
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/http_fetch.c
View File

@ -1079,7 +1079,7 @@ static int smp_fetch_base32_src(const struct arg *args, struct sample *smp, cons
struct buffer *temp; struct buffer *temp;
struct connection *cli_conn = objt_conn(smp->sess->origin); struct connection *cli_conn = objt_conn(smp->sess->origin);
if (!cli_conn) if (!cli_conn || !conn_get_src(cli_conn))
return 0; return 0;
if (!smp_fetch_base32(args, smp, kw, private)) if (!smp_fetch_base32(args, smp, kw, private))
@ -1784,7 +1784,7 @@ static int smp_fetch_url32_src(const struct arg *args, struct sample *smp, const
struct buffer *temp; struct buffer *temp;
struct connection *cli_conn = objt_conn(smp->sess->origin); struct connection *cli_conn = objt_conn(smp->sess->origin);
if (!cli_conn) if (!cli_conn || !conn_get_src(cli_conn))
return 0; return 0;
if (!smp_fetch_url32(args, smp, kw, private)) if (!smp_fetch_url32(args, smp, kw, private))