mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-09-21 13:51:26 +02:00
Code Issues Projects Releases Wiki Activity

CLEANUP: queue: Remove useless tests on p or pp in pendconn_process_next_strm()

Browse Source 
This patch removes unecessary tests on p or pp pointers in
pendconn_process_next_strm() function. This should make cppcheck happy and
avoid false report of null pointer dereference.

This patch should fix the issue #1036.
This commit is contained in:
Christopher Faulet 2021-02-11 11:13:33 +01:00
parent a1e0f387c7
commit cd7126b396
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/queue.c
View File

@ -281,12 +281,12 @@ static int pendconn_process_next_strm(struct server *srv, struct proxy *px)
if (!p && !pp) if (!p && !pp)
return 0; return 0;
else if (!pp)
goto use_p; /* p != NULL */
else if (!p)
goto use_pp; /* pp != NULL */
if (p && !pp) /* p != NULL && pp != NULL*/
goto use_p;
if (pp && !p)
goto use_pp;
if (KEY_CLASS(p->node.key) < KEY_CLASS(pp->node.key)) if (KEY_CLASS(p->node.key) < KEY_CLASS(pp->node.key))
goto use_p; goto use_p;