mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-08-09 16:47:18 +02:00
Code Issues Projects Releases Wiki Activity

MINOR: cache: Remove useless test for nonzero.

Browse Source 
Don't bother testing if len is nonzero, we know it is, as we're in the
"else" part of a if (!len), and testing it confuses clang into thinking
ret may be left uninitialized.
This commit is contained in:
Olivier Houchard 2017-11-01 13:58:21 +01:00 committed by Willy Tarreau
parent 7da120bb0e
commit cd2867a012
1 changed files with 19 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/cache.c
View File

@ -173,7 +173,6 @@ cache_store_http_forward_data(struct stream *s, struct filter *filter,
} }
else { else {
/* Forward trailers data */ /* Forward trailers data */
if (len) {
if (filter->ctx && st->first_block) { if (filter->ctx && st->first_block) {
/* disable buffering if too much data (never greater than a buffer size */ /* disable buffering if too much data (never greater than a buffer size */
if (len > global.tune.bufsize - global.tune.maxrewrite - st->first_block->len) { if (len > global.tune.bufsize - global.tune.maxrewrite - st->first_block->len) {
@ -197,7 +196,6 @@ cache_store_http_forward_data(struct stream *s, struct filter *filter,
ret = len; ret = len;
} }
} }
}
if ((ret != len) || if ((ret != len) ||
(FLT_NXT(filter, msg->chn) != FLT_FWD(filter, msg->chn) + ret)) (FLT_NXT(filter, msg->chn) != FLT_FWD(filter, msg->chn) + ret))