mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-09-22 14:21:25 +02:00
Code Issues Projects Releases Wiki Activity

DEBUG: thread: add 5 extra lock labels for statistics and debugging

Browse Source 
Since OTHER_LOCK is commonly used it's become much more difficult to
profile lock contention by temporarily changing a lock label. Let's
add DEBUG1..5 to serve only for debugging. These ones must not be
used in committed code. We could decide to only define them when
DEBUG_THREAD is set but that would complicate attempts at measuring
performance with debugging turned off.
This commit is contained in:
Willy Tarreau 2021-02-17 14:33:58 +01:00
parent 4e9df2737d
commit ccea3c54f4
1 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
include/haproxy/thread.h
View File

@ -402,6 +402,14 @@ enum lock_label {
SFT_LOCK, /* sink forward target */ SFT_LOCK, /* sink forward target */
IDLE_CONNS_LOCK, IDLE_CONNS_LOCK,
OTHER_LOCK, OTHER_LOCK,
/* WT: make sure never to use these ones outside of development,
* we need them for lock profiling!
*/
DEBUG1_LOCK,
DEBUG2_LOCK,
DEBUG3_LOCK,
DEBUG4_LOCK,
DEBUG5_LOCK,
LOCK_LABELS LOCK_LABELS
}; };
@ -447,6 +455,11 @@ static inline const char *lock_label(enum lock_label label)
case SFT_LOCK: return "SFT"; case SFT_LOCK: return "SFT";
case IDLE_CONNS_LOCK: return "IDLE_CONNS"; case IDLE_CONNS_LOCK: return "IDLE_CONNS";
case OTHER_LOCK: return "OTHER"; case OTHER_LOCK: return "OTHER";
case DEBUG1_LOCK: return "DEBUG1";
case DEBUG2_LOCK: return "DEBUG2";
case DEBUG3_LOCK: return "DEBUG3";
case DEBUG4_LOCK: return "DEBUG4";
case DEBUG5_LOCK: return "DEBUG5";
case LOCK_LABELS: break; /* keep compiler happy */ case LOCK_LABELS: break; /* keep compiler happy */
}; };
/* only way to come here is consecutive to an internal bug */ /* only way to come here is consecutive to an internal bug */