From ccea010104235ae74c59e216c73667125e5d24ad Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Tue, 31 May 2022 08:49:29 +0200 Subject: [PATCH] BUG/MEDIUM: peers/cli: fix "show peers" crash Commit d0a06d52f ("CLEANUP: applet: use applet_put*() everywhere possible") replaced most accesses to the conn_stream with simpler accesses to the appctx. Unfortunately, in all the CLI functions using an appctx, one makes an exception where the appctx is not the caller's but the one being inspected! When no peers connection is active, the early exit immediately crashes. No backport is needed. --- src/peers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/peers.c b/src/peers.c index da83a7999..6dfa35f8e 100644 --- a/src/peers.c +++ b/src/peers.c @@ -3917,7 +3917,7 @@ static int peers_dump_peer(struct buffer *msg, struct stconn *sc, struct peer *p end: chunk_appendf(&trash, "\n"); - if (applet_putchk(appctx, msg) == -1) + if (applet_putchk(sc_appctx(sc), msg) == -1) return 0; return 1;