From c877bd4ea5dba14738bbf565df13d3016eb52bb3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20L=C3=A9caille?= Date: Mon, 3 Apr 2023 13:01:58 +0200 Subject: [PATCH] BUG/MINOR: quic: Remove useless BUG_ON() in newreno and cubic algo implementation As now_ms may be zero, these BUG_ON() could be triggered when its value has wrapped. These call to BUG_ON() may be removed because the values they was supposed to check are safely used by the ticks API. Must be backported to 2.6 and 2.7. --- src/quic_cc_cubic.c | 2 -- src/quic_cc_newreno.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/src/quic_cc_cubic.c b/src/quic_cc_cubic.c index 4d31cc725..1a5fa4e5b 100644 --- a/src/quic_cc_cubic.c +++ b/src/quic_cc_cubic.c @@ -263,8 +263,6 @@ static void quic_cc_cubic_rp_cb(struct quic_cc *cc, struct quic_cc_event *ev) TRACE_ENTER(QUIC_EV_CONN_CC, cc->qc, ev); TRACE_PROTO("CC cubic", QUIC_EV_CONN_CC, cc->qc, ev, cc); - BUG_ON(!tick_isset(c->recovery_start_time)); - switch (ev->type) { case QUIC_CC_EVT_ACK: /* RFC 9022 7.3.2. Recovery diff --git a/src/quic_cc_newreno.c b/src/quic_cc_newreno.c index f1566ba8a..4d9bf136a 100644 --- a/src/quic_cc_newreno.c +++ b/src/quic_cc_newreno.c @@ -146,8 +146,6 @@ static void quic_cc_nr_rp_cb(struct quic_cc *cc, struct quic_cc_event *ev) struct quic_path *path; struct nr *nr = quic_cc_priv(cc); - BUG_ON(!tick_isset(nr->recovery_start_time)); - TRACE_ENTER(QUIC_EV_CONN_CC, cc->qc); TRACE_PROTO("CC reno", QUIC_EV_CONN_CC, cc->qc, ev); path = container_of(cc, struct quic_path, cc);