mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2026-03-23 16:01:14 +01:00
Code Issues Projects Releases Wiki Activity

BUG/MINOR: config: Limit "tune.maxpollevents" parameter to 1000000

Browse Source 
"tune.maxpollevents" global parameter was not limited. It was possible to
set any integer value. But this value is used to allocate the array of
events used by epoll. With a huge value, it seems the allocation silently
fail, making haproxy totally unresponsive.

So let's to limit its value to 1 million. It is pretty high and it should
not be an issue to forbid greater values. The documentation was updated
accordingly.

This patch could be backported to all stable branches.
This commit is contained in:
Christopher Faulet 2025-11-06 15:51:27 +01:00
parent 80edbad4f9
commit c6f68901cc
2 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
doc/configuration.txt
View File

@ -4612,7 +4612,8 @@ tune.maxpollevents <number>
the polling system. The default value is adapted to the operating system. It
has been noticed that reducing it below 200 tends to slightly decrease
latency at the expense of network bandwidth, and increasing it above 200
tends to trade latency for slightly increased bandwidth.
tends to trade latency for slightly increased bandwidth. The configured value
must be lower than or equal to 1000000.
tune.maxrewrite <number>
Sets the reserved buffer space to this size in bytes. The reserved space is

10
src/cfgparse-global.c
View File

@ -1134,6 +1134,8 @@ static int cfg_parse_global_tune_opts(char **args, int section_type,
}
else if (strcmp(args[0], "tune.maxpollevents") == 0) {
long max;
if (global.tune.maxpollevents != 0) {
memprintf(err, "'%s' already specified. Continuing.", args[0]);
return 1;
@ -1142,8 +1144,12 @@ static int cfg_parse_global_tune_opts(char **args, int section_type,
memprintf(err, "'%s' expects an integer argument.", args[0]);
return -1;
}
global.tune.maxpollevents = atol(args[1]);
max = atol(args[1]);
if (max > 1000000) {
memprintf(err, "'%s' expects an integer value lower than or equal to 1000000.", args[0]);
return -1;
}
global.tune.maxpollevents = max;
return 0;
}
else if (strcmp(args[0], "tune.max-rules-at-once") == 0) {