CLEANUP: Apply strcmp.cocci

This fixes the use of the various *cmp functions to use != 0 or == 0.
This commit is contained in:
Tim Duesterhus 2021-10-16 17:48:15 +02:00 committed by Willy Tarreau
parent bce9108a1f
commit c5aa113d80
3 changed files with 4 additions and 4 deletions

View File

@ -1536,7 +1536,7 @@ static void check_section_position(char *section_name,
const char *file, int linenum, const char *file, int linenum,
int *non_global_parsed) int *non_global_parsed)
{ {
if (!strcmp(section_name, "global")) { if (strcmp(section_name, "global") == 0) {
if (*non_global_parsed == 1) if (*non_global_parsed == 1)
_ha_diag_warning("parsing [%s:%d] : global section detected after a non-global one, the prevalence of their statements is unspecified\n", file, linenum); _ha_diag_warning("parsing [%s:%d] : global section detected after a non-global one, the prevalence of their statements is unspecified\n", file, linenum);
} }

View File

@ -1714,11 +1714,11 @@ static int cli_parse_expert_experimental_mode(char **args, char *payload, struct
if (!cli_has_level(appctx, ACCESS_LVL_ADMIN)) if (!cli_has_level(appctx, ACCESS_LVL_ADMIN))
return 1; return 1;
if (!strcmp(args[0], "expert-mode")) { if (strcmp(args[0], "expert-mode") == 0) {
level = ACCESS_EXPERT; level = ACCESS_EXPERT;
level_str = "expert-mode"; level_str = "expert-mode";
} }
else if (!strcmp(args[0], "experimental-mode")) { else if (strcmp(args[0], "experimental-mode") == 0) {
level = ACCESS_EXPERIMENTAL; level = ACCESS_EXPERIMENTAL;
level_str = "experimental-mode"; level_str = "experimental-mode";
} }

View File

@ -4681,7 +4681,7 @@ static int cli_parse_add_server(char **args, char *payload, struct appctx *appct
while (1) { while (1) {
/* check for duplicate server */ /* check for duplicate server */
if (!strcmp(srv->id, next->id)) { if (strcmp(srv->id, next->id) == 0) {
ha_alert("Already exists a server with the same name in backend.\n"); ha_alert("Already exists a server with the same name in backend.\n");
goto out; goto out;
} }