From c57fb3be75d0cd36919ce94d5ef1d13ee6b15f98 Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Thu, 29 Dec 2022 11:11:02 +0100 Subject: [PATCH] MINOR: cfgparse-ssl: avoid a possible crash on OOM in ssl_bind_parse_npn() Upon out of memory condition at boot, we could possibly crash when parsing the "npn" bind line keyword since it's used unchecked. There's no real need to backport this though it will not hurt. --- src/cfgparse-ssl.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/cfgparse-ssl.c b/src/cfgparse-ssl.c index 4f999e106..75af0e838 100644 --- a/src/cfgparse-ssl.c +++ b/src/cfgparse-ssl.c @@ -1016,6 +1016,11 @@ static int ssl_bind_parse_npn(char **args, int cur_arg, struct proxy *px, struct */ conf->npn_len = strlen(args[cur_arg + 1]) + 1; conf->npn_str = calloc(1, conf->npn_len + 1); + if (!conf->npn_str) { + memprintf(err, "out of memory"); + return ERR_ALERT | ERR_FATAL; + } + memcpy(conf->npn_str + 1, args[cur_arg + 1], conf->npn_len); /* replace commas with the name length */