mirror of
https://git.haproxy.org/git/haproxy.git/
synced 2025-09-23 06:41:32 +02:00
BUG/MEDIUM: task: fix recently introduced scheduler skew
Commit 501260b ("MEDIUM: task: always ensure that the run queue is consistent") introduced a skew in the scheduler : if a negatively niced task is woken up, it can be inserted prior to the current index and will be skipped as long as there is some activity with less prioritary tasks. The immediate effect is that it's not possible to get access to the stats under full load until the load goes down. This is because the rq_next constantly evolves within more recent positions. The fix is simple, __task_wakeup() must empty rq_next. The sad thing is that this issue was fixed during development and missed during the commit. No backport is needed, this is purely 1.6 stuff.
This commit is contained in:
parent
d44731fca0
commit
c46c965540
@ -65,6 +65,7 @@ struct task *__task_wakeup(struct task *t)
|
|||||||
t->state &= ~TASK_WOKEN_ANY;
|
t->state &= ~TASK_WOKEN_ANY;
|
||||||
|
|
||||||
eb32_insert(&rqueue, &t->rq);
|
eb32_insert(&rqueue, &t->rq);
|
||||||
|
rq_next = NULL;
|
||||||
return t;
|
return t;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
Loading…
x
Reference in New Issue
Block a user